Hi, I don't believe this is the case. By following the current code sequence from git d1bb9ecbd5a77cdb8d93accfa8c1bbf705002de0
In port.c:2259 we receive a packet, and the packet is rightly tagged as a management msg type in the common message header, and we're thus forwarded to the clock_manage function. In the clock_manage function there is no check on what the TLV type is. It's just assumed that the TLV type is 1, and thus the packet is incorrectly parsed. Below is a snippet of the packet. PTP payload starts at 0x2A. 0000 01 00 5e 00 01 81 ec 46 70 00 bf 9a 08 00 45 00 ..^....Fp.....E. 0010 00 80 2a 93 40 00 05 11 ba d9 ac 1b 02 64 e0 00 ..*.@........d.. 0020 01 81 01 40 01 40 00 6c c6 e5 0d 02 00 64 00 00 ...@.@.l.....d.. 0030 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ec 46 ...............F 0040 70 ff fe 00 bf 9a 00 01 74 c8 04 7f ff ff ff ff p.......t....... 0050 ff ff ff ff ff ff 01 01 03 00 00 03 00 30 68 97 .............0h. 0060 e8 00 00 01 00 00 00 19 00 00 00 01 01 00 ff ff ................ 0070 ff db 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 0080 00 00 ff ff ff fe ae 80 ff ff ff db 00 00 .............. Thanks, Morten On Fri, May 12, 2017 at 10:16 AM, Richard Cochran <richardcoch...@gmail.com> wrote: > On Fri, May 12, 2017 at 09:03:51AM +0200, Morten Flå wrote: >> I'm currently testing a PTP Grandmaster clock that has the ability to >> send out Organization Extension TLVs. However, it seems like ptp4l >> treats these messages as a normal management message. The result of >> this is that ptp4l evaluates the organizationId field as the >> managementId, as they are located at the same byte offset. > > Management messages have TLV type 1. > > Organization Extenstion messages have TLV type 3. > > Sounds like your GM is sending Organization Extenstion message with > TLV type 1. That would be wrong. > > Thanks, > Richard > > > > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linuxptp-users mailing list Linuxptp-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-users
