Hi!
First of all, let me thank you for LS, it's the first decent Linux Pro
Audio application I've seen. I wish more programs would have LS's
quality, especially some sound synthesis applications. (anything
comparable to Steinberg Hypersonic for Linux? ;)
Find attached two patches for the debian directory. LS's "make doc"
requires doxygen. This bug was probably masked, since everybody compiled
libgig first, which also needs doxygen.
Second patch: refactor the CXXFLAGS so there's no need to change them,
twice. The patch actually does a little bit more, you might want to
remove or comment out my initial setting of CXXFLAGS.
On the other hand, it's probably worth shipping it (commented out) as an
example. Providing the user with sample lines for e.g. Athlon, P4,
CoreDuo and so on might ease the setup. (don't expect the average real
world musician to know anything about compiler flags)
Three usability comments:
I wasn't able to check existing bugs in the database. The site has a
selfsigned SSL certificate and Firefox3 requires me (and everyone else)
to set up a certificate exception. Since bugs are not private, I don't
see the hard requirement for https. The Debian BTS is way easier to use:
simply write a mail to submit or comment, check the webinterface for
existing bugs.
In Fantasia, when you open a script and there's no connection to an LS
backend, you'd end up with tons of windows saying "broken pipe". The
amount of windows is directly related to the commands in the script -
every command fails and produces a new error window.
I suggest to stop script execution upon broken pipes. If the connection
is down, no further command would be useful.
Last remark: provide a "reconnect" entry. Now and then, the backend
dies, but the frontend (Fantasia) remains active. The user needs to call
"Change backend" in order to connect again. I only have one LS instance,
so I constantly change my backend to 127.0.0.1:8888, all the time.
A simple "reconnect" menu entry would drop any remaining or believed
backend connection and open a new one. It can implemented via the
"change backend" functions.
--
mail: a...@thur.de http://adi.thur.de PGP/GPG: key via keyserver
Index: debian/control
===================================================================
RCS file: /var/cvs/linuxsampler/linuxsampler/debian/control,v
retrieving revision 1.5
diff -u -r1.5 control
--- debian/control 28 May 2008 04:00:48 -0000 1.5
+++ debian/control 7 Jan 2009 20:48:19 -0000
@@ -2,7 +2,7 @@
Section: sound
Priority: optional
Maintainer: Matt Flax <flat...@pgb.unsw.edu.au>
-Build-Depends: debhelper (>= 4.0.0), libgig-dev, uuid-dev
+Build-Depends: debhelper (>= 4.0.0), libgig-dev, uuid-dev, doxygen
Standards-Version: 3.6.1
Package: linuxsampler
Index: debian/rules
===================================================================
RCS file: /var/cvs/linuxsampler/linuxsampler/debian/rules,v
retrieving revision 1.7
diff -u -r1.7 rules
--- debian/rules 5 Jun 2007 15:55:05 -0000 1.7
+++ debian/rules 7 Jan 2009 20:45:56 -0000
@@ -17,6 +17,8 @@
CFLAGS += -O2
endif
+CXXFLAGS= -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -O2 -march=athlon64 -ffast-math -fomit-frame-pointer -funroll-loops
+
configure: configure-stamp
configure-stamp:
dh_testdir
@@ -25,7 +27,7 @@
$(MAKE) -f Makefile.cvs; \
fi
chmod a+x configure
- ./configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr --mandir=\$${prefix}/share/man --infodir=\$${prefix}/share/info
+ CXXFLAGS="${CXXFLAGS}" ./configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr --mandir=\$${prefix}/share/man --infodir=\$${prefix}/share/info
touch configure-stamp
@@ -55,7 +57,7 @@
fi;
# Add here commands to clean up after the build process.
chmod a+x configure
- ./configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr --mandir=\$${prefix}/share/man --infodir=\$${prefix}/share/info
+ CXXFLAGS="${CXXFLAGS}" ./configure --host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr --mandir=\$${prefix}/share/man --infodir=\$${prefix}/share/info
-$(MAKE) distclean
------------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It is the best place to buy or sell services for
just about anything Open Source.
http://p.sf.net/sfu/Xq1LFB
_______________________________________________
Linuxsampler-devel mailing list
Linuxsampler-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
