On Saturday 24 October 2009 14:20:25 Andreas Persson wrote: > The ambitious solution is to extract the RIFF functions to a separate > library, and let libsf2 and libgig depend on that. An alternative is to > make libsf2 dependent on libgig. The third option is to simply put the > sf2 functions into libgig. I vote for the last one - the sf2 > functionality is too small in my opinion to motivate a split of libgig.
I vote for either of the last two solutions. That is, either to make libsf(2) dependent on libgig or to merge libsf2 into libgig. Btw, I would definitely kill the 2 digit in the library name. Doesn't make sense to have that in the name and would cause problems in future. > Another question is what to do with the redeclaration warnings you get > if you include both SF.h and gig.h, like this one: > > warning: "CHUNK_ID_SMPL" redefined > > First suggestion was to rename the ones in SF.h with a SF_ prefix. I > think that is a bit ugly, as it really is the same constant after all. I > would instead vote for moving the common IDs to RIFF.h. But this, as > Grigor told me, is not very clean as you add format specific info the > general riff class. So, Grigor and I couldn't decide. Anyone have an > opinion on this (not very important) matter? I would probably just include gig.h in sf.h CU Christian ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Linuxsampler-devel mailing list Linuxsampler-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
