On Fri, 2011-10-21 at 13:51 +0200, Christian Schoenebeck wrote: > On Thursday 20 October 2011 13:25:48 Dan MacDonald wrote: > > Hi Dave! > > > > On Wed, Oct 19, 2011 at 11:22 PM, David Robillard <d...@drobilla.net> wrote: > > > Hello, > > > > > > Attached is a patch that fixes a NULL pointer dereference problem that > > > occurs when LinuxSampler is restored as an LV2 in Ardour 3.0. > > > > Just tried your patch under Wheezy x64 and the latest A3 still > > segfaults here when trying to open a session containing the LS LV2 > > unfortunately. > > Hi guys! > > Does this crash occur under certain conditions, e.g. when gigedit was opened > before or something? Or does this crash always happen, no matter what the > exact circumstances are?
I am not sure, but presumably it is because the state is being loaded before the plugin is activated (i.e. before the LS engine is started). Either way, the patch is a straightforward fix for a potential crash (the code was already taking into consideration the possibility of not getting the information from the engine, it just crashed in one of those cases). It could perhaps be argued that plugins must only be restored after they are activated? -dr ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ Linuxsampler-devel mailing list Linuxsampler-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
