Hello,
The LV2 persist extension implemented in my previous patch (and LS SVN)
turned out to need a bit of future proofing.
Attached is a patch to support its replacement, "LV2 State",
http://lv2plug.in/ns/ext/state
Tested working with latest ardour3 svn. A new Ardour 3 beta supporting
this (and not the old persist) is due out extremely soon, so applying
this to svn would be appreciated. I will do qtractor soon as well.
Cheers,
-dr
Index: src/hostplugins/lv2/lv2_persist.h
===================================================================
--- src/hostplugins/lv2/lv2_persist.h (revision 2281)
+++ src/hostplugins/lv2/lv2_persist.h (working copy)
@@ -1,228 +0,0 @@
-/*
- Copyright 2010-2011 David Robillard <http://drobilla.net>
- Copyright 2010 Leonard Ritter <pa...@paniq.org>
-
- This header is free software; you can redistribute it and/or modify it
- under the terms of the GNU Lesser General Public License as published
- by the Free Software Foundation; either version 2 of the License, or
- (at your option) any later version.
-
- This header is distributed in the hope that it will be useful, but WITHOUT
- ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public
- License for more details.
-
- You should have received a copy of the GNU Lesser General Public License
- along with this header; if not, write to the Free Software Foundation,
- Inc., 59 Temple Place, Suite 330, Boston, MA 01222-1307 USA
-*/
-
-/**
- @file
- C API for the LV2 Persist extension <http://lv2plug.in/ns/ext/persist>.
-*/
-
-#ifndef LV2_PERSIST_H
-#define LV2_PERSIST_H
-
-#include <stdbool.h>
-#include <stdint.h>
-
-#ifdef __cplusplus
-extern "C" {
-#endif
-
-#define LV2_PERSIST_URI "http://lv2plug.in/ns/ext/persist";
-
-/**
- Flags describing value characteristics.
-
- These flags are used along with the value's type URI to determine how to
- (de-)serialise the value data, or whether it is even possible to do so.
-*/
-typedef enum {
-
- /**
- Plain Old Data.
-
- Values with this flag contain no references to non-persistent or
- non-global resources (e.g. pointers, handles, local paths, etc.). It is
- safe to copy POD values with a simple memcpy and store them for use at
- any time in the future on a machine with a compatible architecture
- (e.g. the same endianness and alignment).
-
- Implementations MUST NOT attempt to copy or serialise a non-POD value if
- they do not understand its type (and thus know how to correctly do so).
- */
- LV2_PERSIST_IS_POD = 1,
-
- /**
- Portable (architecture independent) data.
-
- Values with this flag are in a format that is usable on any
- architecture, i.e. if the value is saved on one machine it can safely be
- restored on another machine regardless of endianness, alignment, etc.
- */
- LV2_PERSIST_IS_PORTABLE = 1 << 1
-
-} LV2_Persist_Flags;
-
-/**
- A host-provided function to store a property.
- @param callback_data Must be the callback_data passed to LV2_Persist.save().
- @param key The key (predicate) to store @a value under (URI mapped integer).
- @param value Pointer to the value (object) to be stored.
- @param size The size of the data at @a value in bytes.
- @param type The type of @a value (URI).
- @param flags LV2_Persist_Flags for @a value.
- @return 0 on success, otherwise a non-zero error code.
-
- The host passes a callback of this type to LV2_Persist.save(). This callback
- is called repeatedly by the plugin within LV2_Persist.save() to store all
- the statements that describe its current state.
-
- The host MAY fail to store a property if the type is not understood and is
- not LV2_PERSIST_IS_POD and/or LV2_PERSIST_IS_PORTABLE. Implementations are
- encouraged to use POD and portable values (e.g. string literals) wherever
- possible, and use common types (e.g. types from
- http://lv2plug.in/ns/ext/atom) regardless, since hosts are likely to already
- contain the necessary implementation.
-
- Note that @a size MUST be > 0, and @a value MUST point to a valid region of
- memory @a size bytes long (this is required to make restore unambiguous).
-
- The plugin MUST NOT attempt to use this function outside of the
- LV2_Persist.restore() context.
-*/
-typedef int (*LV2_Persist_Store_Function)(
- void* callback_data,
- uint32_t key,
- const void* value,
- size_t size,
- uint32_t type,
- uint32_t flags);
-
-/**
- A host-provided function to retrieve a property.
- @param callback_data Must be the callback_data passed to LV2_Persist.restore().
- @param key The key (predicate) of the property to retrieve (URI).
- @param size (Output) If non-NULL, set to the size of the restored value.
- @param type (Output) If non-NULL, set to the type of the restored value.
- @param flags (Output) If non-NULL, set to the LV2_Persist_Flags for
- the returned value.
- @return A pointer to the restored value (object), or NULL if no value
- has been stored under @a key.
-
- A callback of this type is passed by the host to LV2_Persist.restore(). This
- callback is called repeatedly by the plugin within LV2_Persist.restore() to
- retrieve any properties it requires to restore its state.
-
- The returned value MUST remain valid until LV2_Persist.restore() returns.
-
- The plugin MUST NOT attempt to use this function, or any value returned from
- it, outside of the LV2_Persist.restore() context. Returned values MAY be
- copied for later use if necessary, assuming the plugin knows how to do so
- correctly (e.g. the value is POD, or the plugin understands the type).
-*/
-typedef const void* (*LV2_Persist_Retrieve_Function)(
- void* callback_data,
- uint32_t key,
- size_t* size,
- uint32_t* type,
- uint32_t* flags);
-
-/**
- Persist Extension Data.
-
- When the plugin's extension_data is called with argument LV2_PERSIST_URI,
- the plugin MUST return an LV2_Persist structure, which remains valid for the
- lifetime of the plugin.
-
- The host can use the contained function pointers to save and restore the
- state of a plugin instance at any time (provided the threading restrictions
- for the given function are met).
-
- The typical use case is to save the plugin's state when a project is saved,
- and to restore the state when a project has been loaded. Other uses are
- possible (e.g. cloning plugin instances or taking a snapshot of plugin
- state).
-
- Stored data is only guaranteed to be compatible between instances of plugins
- with the same URI (i.e. if a change to a plugin would cause a fatal error
- when restoring state saved by a previous version of that plugin, the plugin
- URI MUST change just as it must when ports change incompatibly). Plugin
- authors should consider this possibility, and always store sensible data
- with meaningful types to avoid such compatibility issues in the future.
-*/
-typedef struct _LV2_Persist {
-
- /**
- Save plugin state using a host-provided @a store callback.
-
- @param instance The instance handle of the plugin.
- @param store The host-provided store callback.
- @param callback_data An opaque pointer to host data, e.g. the map or
- file where the values are to be stored. If @a store is called,
- this MUST be passed as its callback_data parameter.
-
- The plugin is expected to store everything necessary to completely
- restore its state later (possibly much later, in a different process, on
- a completely different machine, etc.)
-
- The @a callback_data pointer and @a store function MUST NOT be used
- beyond the scope of save().
-
- This function has its own special threading class: it may not be called
- concurrently with any "Instantiation" function, but it may be called
- concurrently with functions in any other class, unless the definition of
- that class prohibits it (e.g. it may not be called concurrently with a
- "Discovery" function, but it may be called concurrently with an "Audio"
- function. The plugin is responsible for any locking or lock-free
- techniques necessary to make this possible.
-
- Note that in the simple case where state is only modified by restore(),
- there are no synchronization issues since save() is never called
- concurrently with restore() (though run() may read it during a save).
-
- Plugins that dynamically modify state while running, however, must take
- care to do so in such a way that a concurrent call to save() will save a
- consistent representation of plugin state for a single instant in time.
- */
- void (*save)(LV2_Handle instance,
- LV2_Persist_Store_Function store,
- void* callback_data);
-
- /**
- Restore plugin state using a host-provided @a retrieve callback.
-
- @param instance The instance handle of the plugin.
- @param retrieve The host-provided retrieve callback.
- @param callback_data An opaque pointer to host data, e.g. the map or
- file from which the values are to be restored. If @a retrieve is
- called, this MUST be passed as its callback_data parameter.
-
- The plugin MAY assume a restored value was set by a previous call to
- LV2_Persist.save() by a plugin with the same URI.
-
- The plugin MUST gracefully fall back to a default value when a value can
- not be retrieved. This allows the host to reset the plugin state with an
- empty map.
-
- The @a callback_data pointer and @a store function MUST NOT be used
- beyond the scope of restore().
-
- This function is in the "Instantiation" threading class as defined by
- LV2. This means it MUST NOT be called concurrently with any other
- function on the same plugin instance.
- */
- void (*restore)(LV2_Handle instance,
- LV2_Persist_Retrieve_Function retrieve,
- void* callback_data);
-
-} LV2_Persist;
-
-#ifdef __cplusplus
-} /* extern "C" */
-#endif
-
-#endif /* LV2_PERSIST_H */
Index: src/hostplugins/lv2/PluginLv2.cpp
===================================================================
--- src/hostplugins/lv2/PluginLv2.cpp (revision 2281)
+++ src/hostplugins/lv2/PluginLv2.cpp (working copy)
@@ -124,7 +124,7 @@
return path;
}
- void PluginLv2::Save(LV2_Persist_Store_Function store, void* host_data) {
+ void PluginLv2::Save(LV2_State_Store_Function store, LV2_State_Handle handle) {
if (NewFileSupport) {
char* path = NewFileSupport->new_file_path(PathSupport->host_data,
"linuxsampler");
@@ -135,35 +135,35 @@
const String abstract_path = PathToState(path);
- store(host_data,
+ store(handle,
uri_to_id(NULL, NS_LS "state-file"),
abstract_path.c_str(),
abstract_path.length() + 1,
uri_to_id(NULL, LV2_FILES_URI "#AbstractPath"),
- LV2_PERSIST_IS_PORTABLE);
+ LV2_STATE_IS_PORTABLE);
} else {
dmsg(2, ("saving to string\n"));
std::ostringstream out;
out << GetState();
- store(host_data,
+ store(handle,
uri_to_id(NULL, NS_LS "state-string"),
out.str().c_str(),
out.str().length() + 1,
uri_to_id(NULL, NS_ATOM "String"),
- LV2_PERSIST_IS_POD | LV2_PERSIST_IS_PORTABLE);
+ LV2_STATE_IS_POD | LV2_STATE_IS_PORTABLE);
}
dmsg(2, ("saving done\n"));
}
- void PluginLv2::Restore(LV2_Persist_Retrieve_Function retrieve, void* data) {
+ void PluginLv2::Restore(LV2_State_Retrieve_Function retrieve, LV2_State_Handle handle) {
size_t size;
uint32_t type;
uint32_t flags;
const void* value = retrieve(
- data,
+ handle,
uri_to_id(NULL, NS_LS "state-file"),
&size, &type, &flags);
@@ -179,7 +179,7 @@
}
value = retrieve(
- data,
+ handle,
uri_to_id(NULL, NS_LS "state-string"),
&size, &type, &flags);
if (value) {
@@ -221,12 +221,14 @@
delete static_cast<PluginLv2*>(instance);
}
- void save(LV2_Handle handle, LV2_Persist_Store_Function store, void* callback_data) {
- return static_cast<PluginLv2*>(handle)->Save(store, callback_data);
+ void save(LV2_Handle handle, LV2_State_Store_Function store, LV2_State_Handle state,
+ uint32_t flags, const LV2_Feature* const* features) {
+ return static_cast<PluginLv2*>(handle)->Save(store, state);
}
- void restore(LV2_Handle handle, LV2_Persist_Retrieve_Function store, void* callback_data) {
- return static_cast<PluginLv2*>(handle)->Restore(store, callback_data);
+ void restore(LV2_Handle handle, LV2_State_Retrieve_Function retrieve, LV2_State_Handle state,
+ uint32_t flags, const LV2_Feature* const* features) {
+ return static_cast<PluginLv2*>(handle)->Restore(retrieve, state);
}
PluginInfo PluginInfo::Instance;
@@ -240,15 +242,15 @@
Lv2.instantiate = instantiate;
Lv2.run = run;
Lv2.extension_data = extension_data;
- Persist.save = save;
- Persist.restore = restore;
+ StateInterface.save = save;
+ StateInterface.restore = restore;
}
const void* extension_data(const char* uri) {
dmsg(2, ("linuxsampler: extension_data %s\n", uri));
- if (strcmp(uri, LV2_PERSIST_URI) == 0) {
- return PluginInfo::Lv2PersistDescriptor();
+ if (strcmp(uri, LV2_STATE_URI "#Interface") == 0) {
+ return PluginInfo::Lv2StateInterface();
}
return 0;
}
Index: src/hostplugins/lv2/linuxsampler.ttl
===================================================================
--- src/hostplugins/lv2/linuxsampler.ttl (revision 2281)
+++ src/hostplugins/lv2/linuxsampler.ttl (working copy)
@@ -8,7 +8,7 @@
doap:name "LinuxSampler" ;
doap:license <http://linuxsampler.org/downloads.html#exception> ;
lv2:optionalFeature lv2:hardRtCapable ;
- lv2:optionalFeature <http://lv2plug.in/ns/ext/persist> ;
+ lv2:extensionData <http://lv2plug.in/ns/ext/state#Interface> ;
lv2:optionalFeature <http://lv2plug.in/ns/ext/files#pathSupport> ;
lv2:optionalFeature <http://lv2plug.in/ns/ext/files#newFileSupport> ;
lv2:optionalFeature <http://lv2plug.in/ns/ext/uri-map> ;
Index: src/hostplugins/lv2/PluginLv2.h
===================================================================
--- src/hostplugins/lv2/PluginLv2.h (revision 2281)
+++ src/hostplugins/lv2/PluginLv2.h (working copy)
@@ -23,7 +23,7 @@
#include <lv2.h>
#include "lv2_event.h"
-#include "lv2_persist.h"
+#include "lv2_state.h"
#include "lv2_uri_map.h"
#include "lv2_files.h"
#include "../../drivers/Plugin.h"
@@ -39,8 +39,8 @@
void Activate();
void Run(uint32_t SampleCount);
void Deactivate();
- void Save(LV2_Persist_Store_Function store, void* data);
- void Restore(LV2_Persist_Retrieve_Function retrieve, void* data);
+ void Save(LV2_State_Store_Function store, void* data);
+ void Restore(LV2_State_Retrieve_Function retrieve, void* data);
protected:
virtual String PathToState(const String& string);
@@ -65,12 +65,12 @@
static const LV2_Descriptor* Lv2Descriptor() {
return &Instance.Lv2;
}
- static const LV2_Persist* Lv2PersistDescriptor() {
- return &Instance.Persist;
+ static const LV2_State_Interface* Lv2StateInterface() {
+ return &Instance.StateInterface;
}
private:
LV2_Descriptor Lv2;
- LV2_Persist Persist;
+ LV2_State_Interface StateInterface;
PluginInfo();
static PluginInfo Instance;
@@ -88,13 +88,13 @@
static void cleanup(LV2_Handle instance);
static const void* extension_data(const char* uri);
- static void save(LV2_Handle handle,
- LV2_Persist_Store_Function store,
- void* data);
+ static void save(LV2_Handle handle,
+ LV2_State_Store_Function store,
+ void* data);
- static void restore(LV2_Handle handle,
- LV2_Persist_Retrieve_Function retrieve,
- void* data);
+ static void restore(LV2_Handle handle,
+ LV2_State_Retrieve_Function retrieve,
+ void* data);
}
}
Index: src/hostplugins/lv2/Makefile.am
===================================================================
--- src/hostplugins/lv2/Makefile.am (revision 2281)
+++ src/hostplugins/lv2/Makefile.am (working copy)
@@ -5,7 +5,7 @@
plugin_DATA = manifest.ttl linuxsampler.ttl
linuxsampler_la_SOURCES = PluginLv2.cpp PluginLv2.h \
- lv2_event.h lv2_persist.h lv2_uri_map.h lv2_files.h
+ lv2_event.h lv2_state.h lv2_uri_map.h lv2_files.h
linuxsampler_la_LDFLAGS = -module -avoid-version
linuxsampler_la_LIBADD = $(top_builddir)/src/liblinuxsampler.la
endif
Index: src/hostplugins/lv2/lv2_state.h
===================================================================
--- src/hostplugins/lv2/lv2_state.h (revision 0)
+++ src/hostplugins/lv2/lv2_state.h (revision 0)
@@ -0,0 +1,256 @@
+/*
+ Copyright 2010-2011 David Robillard <http://drobilla.net>
+ Copyright 2010 Leonard Ritter <pa...@paniq.org>
+
+ Permission to use, copy, modify, and/or distribute this software for any
+ purpose with or without fee is hereby granted, provided that the above
+ copyright notice and this permission notice appear in all copies.
+
+ THIS SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+*/
+
+/**
+ @file
+ C API for the LV2 State extension <http://lv2plug.in/ns/ext/state>.
+*/
+
+#ifndef LV2_STATE_H
+#define LV2_STATE_H
+
+#include <stdbool.h>
+#include <stddef.h>
+#include <stdint.h>
+
+#include "lv2/lv2plug.in/ns/lv2core/lv2.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#define LV2_STATE_URI "http://lv2plug.in/ns/ext/state";
+
+typedef void* LV2_State_Handle;
+
+/**
+ Flags describing value characteristics.
+
+ These flags are used along with the value's type URI to determine how to
+ (de-)serialise the value data, or whether it is even possible to do so.
+*/
+typedef enum {
+
+ /**
+ Plain Old Data.
+
+ Values with this flag contain no references to non-stateent or
+ non-global resources (e.g. pointers, handles, local paths, etc.). It is
+ safe to copy POD values with a simple memcpy and store them for use at
+ any time in the future on a machine with a compatible architecture
+ (e.g. the same endianness and alignment).
+
+ Implementations MUST NOT attempt to copy or serialise a non-POD value if
+ they do not understand its type (and thus know how to correctly do so).
+ */
+ LV2_STATE_IS_POD = 1,
+
+ /**
+ Portable (architecture independent) data.
+
+ Values with this flag are in a format that is usable on any
+ architecture, i.e. if the value is saved on one machine it can safely be
+ restored on another machine regardless of endianness, alignment, etc.
+ */
+ LV2_STATE_IS_PORTABLE = 1 << 1,
+
+ /**
+ Native data.
+
+ This flag is used by the host to indicate that the saved data is only
+ going to be used locally in the currently running process (e.g. for
+ instance duplication or snapshots), so the plugin should use the most
+ efficient representation possible and not worry about serialisation
+ and portability.
+ */
+ LV2_STATE_IS_NATIVE = 1 << 2
+
+} LV2_State_Flags;
+
+/**
+ A host-provided function to store a property.
+ @param handle Must be the handle passed to LV2_State_Interface.save().
+ @param key The key (predicate) to store @c value under (URI mapped integer).
+ @param value Pointer to the value (object) to be stored.
+ @param size The size of the data at @c value in bytes.
+ @param type The type of @c value (URI).
+ @param flags LV2_State_Flags for @c value.
+ @return 0 on success, otherwise a non-zero error code.
+
+ The host passes a callback of this type to LV2_State_Interface.save(). This callback
+ is called repeatedly by the plugin within LV2_State_Interface.save() to store all
+ the statements that describe its current state.
+
+ The host MAY fail to store a property if the type is not understood and is
+ not LV2_STATE_IS_POD and/or LV2_STATE_IS_PORTABLE. Implementations are
+ encouraged to use POD and portable values (e.g. string literals) wherever
+ possible, and use common types (e.g. types from
+ http://lv2plug.in/ns/ext/atom) regardless, since hosts are likely to already
+ contain the necessary implementation.
+
+ Note that @c size MUST be > 0, and @c value MUST point to a valid region of
+ memory @c size bytes long (this is required to make restore unambiguous).
+
+ The plugin MUST NOT attempt to use this function outside of the
+ LV2_State_Interface.restore() context.
+*/
+typedef int (*LV2_State_Store_Function)(LV2_State_Handle handle,
+ uint32_t key,
+ const void* value,
+ size_t size,
+ uint32_t type,
+ uint32_t flags);
+
+/**
+ A host-provided function to retrieve a property.
+ @param handle Must be the handle passed to
+ LV2_State_Interface.restore().
+ @param key The key (predicate) of the property to retrieve (URI).
+ @param size (Output) If non-NULL, set to the size of the restored value.
+ @param type (Output) If non-NULL, set to the type of the restored value.
+ @param flags (Output) If non-NULL, set to the LV2_State_Flags for
+ the returned value.
+ @return A pointer to the restored value (object), or NULL if no value
+ has been stored under @c key.
+
+ A callback of this type is passed by the host to
+ LV2_State_Interface.restore(). This callback is called repeatedly by the
+ plugin within LV2_State_Interface.restore() to retrieve any properties it
+ requires to restore its state.
+
+ The returned value MUST remain valid until LV2_State_Interface.restore()
+ returns.
+
+ The plugin MUST NOT attempt to use this function, or any value returned from
+ it, outside of the LV2_State_Interface.restore() context. Returned values
+ MAY be copied for later use if necessary, assuming the plugin knows how to
+ do so correctly (e.g. the value is POD, or the plugin understands the type).
+*/
+typedef const void* (*LV2_State_Retrieve_Function)(LV2_State_Handle handle,
+ uint32_t key,
+ size_t* size,
+ uint32_t* type,
+ uint32_t* flags);
+
+/**
+ State Extension Data.
+
+ When the plugin's extension_data is called with argument LV2_STATE_URI,
+ the plugin MUST return an LV2_State structure, which remains valid for the
+ lifetime of the plugin.
+
+ The host can use the contained function pointers to save and restore the
+ state of a plugin instance at any time (provided the threading restrictions
+ for the given function are met).
+
+ The typical use case is to save the plugin's state when a project is saved,
+ and to restore the state when a project has been loaded. Other uses are
+ possible (e.g. cloning plugin instances or taking a snapshot of plugin
+ state).
+
+ Stored data is only guaranteed to be compatible between instances of plugins
+ with the same URI (i.e. if a change to a plugin would cause a fatal error
+ when restoring state saved by a previous version of that plugin, the plugin
+ URI MUST change just as it must when ports change incompatibly). Plugin
+ authors should consider this possibility, and always store sensible data
+ with meaningful types to avoid such compatibility issues in the future.
+*/
+typedef struct _LV2_State_Interface {
+
+ /**
+ Save plugin state using a host-provided @c store callback.
+
+ @param instance The instance handle of the plugin.
+ @param store The host-provided store callback.
+ @param handle An opaque pointer to host data, e.g. the map or
+ file where the values are to be stored. If @c store is called, this MUST
+ be passed as its handle parameter.
+ @param flags Flags describing desires properties of this save. The
+ plugin SHOULD use these values to determine the most appropriate and/or
+ efficient serialisation, but is not required to do so.
+ @param features Extensible parameter for passing any additional
+ features to be used for this save.
+
+ The plugin is expected to store everything necessary to completely
+ restore its state later (possibly much later, in a different process, on
+ a completely different machine, etc.)
+
+ The @c handle pointer and @c store function MUST NOT be used
+ beyond the scope of save().
+
+ This function has its own special threading class: it may not be called
+ concurrently with any "Instantiation" function, but it may be called
+ concurrently with functions in any other class, unless the definition of
+ that class prohibits it (e.g. it may not be called concurrently with a
+ "Discovery" function, but it may be called concurrently with an "Audio"
+ function. The plugin is responsible for any locking or lock-free
+ techniques necessary to make this possible.
+
+ Note that in the simple case where state is only modified by restore(),
+ there are no synchronization issues since save() is never called
+ concurrently with restore() (though run() may read it during a save).
+
+ Plugins that dynamically modify state while running, however, must take
+ care to do so in such a way that a concurrent call to save() will save a
+ consistent representation of plugin state for a single instant in time.
+ */
+ void (*save)(LV2_Handle instance,
+ LV2_State_Store_Function store,
+ LV2_State_Handle handle,
+ uint32_t flags,
+ const LV2_Feature *const * features);
+
+
+ /**
+ Restore plugin state using a host-provided @c retrieve callback.
+
+ @param instance The instance handle of the plugin.
+ @param retrieve The host-provided retrieve callback.
+ @param handle An opaque pointer to host data, e.g. the map or
+ file from which the values are to be restored. If @c retrieve is
+ called, this MUST be passed as its handle parameter.
+ @param flags Currently unused.
+ @param features Extensible parameter for passing any additional
+ features to be used for this restore.
+
+ The plugin MAY assume a restored value was set by a previous call to
+ LV2_State_Interface.save() by a plugin with the same URI.
+
+ The plugin MUST gracefully fall back to a default value when a value can
+ not be retrieved. This allows the host to reset the plugin state with an
+ empty map.
+
+ The @c handle pointer and @c store function MUST NOT be used
+ beyond the scope of restore().
+
+ This function is in the "Instantiation" threading class as defined by
+ LV2. This means it MUST NOT be called concurrently with any other
+ function on the same plugin instance.
+ */
+ void (*restore)(LV2_Handle instance,
+ LV2_State_Retrieve_Function retrieve,
+ LV2_State_Handle handle,
+ uint32_t flags,
+ const LV2_Feature *const * features);
+
+} LV2_State_Interface;
+
+#ifdef __cplusplus
+} /* extern "C" */
+#endif
+
+#endif /* LV2_STATE_H */
Index: src/engines/gig/InstrumentResourceManager.cpp
===================================================================
--- src/engines/gig/InstrumentResourceManager.cpp (revision 2281)
+++ src/engines/gig/InstrumentResourceManager.cpp (working copy)
@@ -604,9 +604,8 @@
// (try to resolve the audio device context)
EngineChannel* pEngineChannel = dynamic_cast<EngineChannel*>(pConsumer);
- AudioOutputDevice* pDevice =
- (pEngineChannel) ? dynamic_cast<Engine*>(pEngineChannel->GetEngine())->pAudioOutputDevice : NULL;
-
+ Engine* pEngine = dynamic_cast<Engine*>(pEngineChannel->GetEngine());
+ AudioOutputDevice* pDevice = (pEngine) ? pEngine->pAudioOutputDevice : NULL;
// and we save this to check if we need to reallocate for a engine with higher value of 'MaxSamplesPerSecond'
pEntry->MaxSamplesPerCycle =
(pDevice) ? pDevice->MaxSamplesPerCycle() : DefaultMaxSamplesPerCycle();
@@ -628,8 +627,8 @@
// (try to resolve the audio device context)
EngineChannel* pEngineChannel = dynamic_cast<EngineChannel*>(pConsumer);
- AudioOutputDevice* pDevice =
- (pEngineChannel) ? dynamic_cast<Engine*>(pEngineChannel->GetEngine())->pAudioOutputDevice : NULL;
+ Engine* pEngine = dynamic_cast<Engine*>(pEngineChannel->GetEngine());
+ AudioOutputDevice* pDevice = (pEngine) ? pEngine->pAudioOutputDevice : NULL;
uint maxSamplesPerCycle =
(pDevice) ? pDevice->MaxSamplesPerCycle() : DefaultMaxSamplesPerCycle();
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Linuxsampler-devel mailing list
Linuxsampler-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
