On Wednesday, July 19, 2017 07:25:50 Andreas Persson wrote: > Christian Schoenebeck wrote: > > Correct me if I am wrong, but as far as I can see it right now, you worked > > on the actual EG curve shapes to replicate the original shapes as > > accurate as possible, for example that the stages are actually a > > combination of linear and logarithmic curves in GSt, and the way the > > durations were calculated by GSt. > > > > However I think that particular issue, that the attack and decay phases > > are > > not played entirely to their end, like it is usually the case with EGs in > > general, is still from the very first EG version that I wrote long time > > before that. So I think I caused that "bug", and you probably did not > > compare this precise behavior aspect with GSt. Am I wrong? > > Yes, I think so. I remember doing measurements on how GSt reacted on > note off in the different stages of EG. I don't remember how much I > actually had to change the implementation, but at least in the comment > of my commit r783 I wrote "Release stage can now start before attack > stage ends."
I see, you are right, that behavior regarding attack and decay came from your side. Then I am going to make that configurable as another LS extension to the gig format and leave the current behavior as default behavior. In the end I will add 3 additional check boxes to gigedit which allow to select for 1.) "attack" stage, 2.) "attack hold" stage and 3.) "decay" stage whether the respective stage should be played entirely to its end on note-off. That checkbox trio will be available for all 3 EGs separately (amp EG, pitch EG, filter EG) as individual configuration. I guess that should be fine for everybody. > > No, that behavior was also from the very first EG version I wrote. I think > > back then I had a piano string in mind, which would stop being dampened as > > soon as you press the piano key down again. And at that point I already > > knew this behavior aspect would deviate from common EG implementations, > > but I did not care. > > Yes, you're right. This sounded familiar, so I had to search the mailing > list archives: It seems I noticed this behavior and asked if it was a > bug in 2004: > https://sourceforge.net/p/linuxsampler/mailman/linuxsampler-devel/thread/14d > f1c3e04120514066f89786d%40mail.gmail.com Ok, then this one doesn't matter anymore. Since I have to add a file format extension for the attack/attack hold/decay behavior configuration, I will also add that one as configurable behavior extension to the gig format as well and leave the current behavior as default one as well. CU Christian ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linuxsampler-devel mailing list Linuxsampler-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
