On Sonntag, 9. Dezember 2018 19:39:23 CET Ivan Maguidhir wrote: > > That makes sense. What does gigdump print as global file information for a > > gig v4 file? > > Here's a link to a zip file containing dumps of all the GSt4 instruments > mentioned.
I applied your libgig patch to SVN and added gig::File::VERSION_4 as new version identifier according to your dumps. Thanks! I also added a new option to gigedit File->Properties->File Format so that one could explicitly store with gig v4 file format. That might help when toying around with new gig v4 features. > Find attached a patch that > prevents the crash by dropping notes. I didn't submit this yesterday as > it's a bit of a hack and I'm not sure if it's correct. The SONiVOX Synth > Pads.gig instrument still doesn't produce the sounds it's supposed to > with this patch. I will try to investigate how GSt4 handles this > instrument if I can get it running in a VM. The patch prevents the crash, that's correct, but the root cause seems to be that your gig file uses a higher sample playback start position than previously max. allowed and expected by the engine. So obviously even with the patch you won't be able to play the instrument correctly. Probably they raised that playback start position limit in v4. Since you are one of the very few people still having a working GSt 4 installation, that might also be valueable to see what maximum playback start position is allowed in the GSt 4 instrument editor. Once we know the max. playback start position in GSt Instr. Editor 4 we can raise that limit on LS side and that would resolve that issue correctly. > > Have you compared this behaviour with your GigaStudio 4 software there? Is > > that what GSt4 does when releasing the sustain pedal? So for instance if > > you press sustain down, then trigger a key with high velocity, then a 2nd > > time the same key with low velocity, then release the sustain pedal, > > would GSt then play a soft release trigger voice? > > Not yet. It's actually years since I've used GSt4. I'm going to try and > get it working in a Windows XP VM this evening. I wrote a piece of > software several years ago for sending MIDI from JACK on Linux to a > driver running in a Windows VM over Ethernet. I hope I can find it > again. Using this I should be able to test the sustain pedal behaviour. Interesting! Might be a useful piece of software for other people as well. :-) I wait a bit before applying your sustain patch to LS. Let's see what test results you get there with GSt 4 on this issue. Thanks! CU Christian _______________________________________________ Linuxsampler-devel mailing list Linuxsampler-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
