Hi Christian
On 23/12/2018 19:51, Christian Schoenebeck wrote:
On libgig side my intention was to only use one subchunk ("LSDE") for all
format extensions that we might introduce on DimensionRegion level.
That's a much better design! Brilliant, thanks!
It did occur to me to try this by giving the new subchunk a version
number but the difficulty was that the chunks ordinarily have to be a
fixed size.
On LS side I had to use a more complex solution, that's because your runtime
check against active voice objects would have its limitations, e.g. when the
regular voice already came to its end (e.g. short sample) then no release
trigger sample would have been triggered since the voice object was gone
already.
It never occurred to me that this would happen. In retrospect and
without cheating by looking at your code I probably would have
maintained a map between key and setting. Thanks for this change as well!
As a side effect of that implementation on LS side, there is now actually
already a code in place for allowing the complete opposite: playing release
trigger samples only on sustain pedal up, but not on note-off. So i wonder
whether I should add that somewhat exotic option to libgig as well?
This could be useful if the note-off release trigger samples in a
particular instrument were annoying / too loud as was the case with a
converted instrument in the thread linked to by Jaime T. I think it
would be a good idea to include it.
CU
Christian
All the best,
Ivan
_______________________________________________
Linuxsampler-devel mailing list
Linuxsampler-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
