On Dienstag, 16. Februar 2021 18:01:06 CET Andrew C wrote:
> Hi Christian,
> 
> Thanks for the timely response and resolution. I did indeed miss that
> configure script warning about uuid, so thanks for putting a hard exit when
> missing the dependency for it.
> 
> Got another make error, this time for gigedit:
> 
> In file included from builtinpix.cpp:2:
> ../compat.h: In member function ‘void
> MultiLineLabel::get_preferred_height_for_width_vfunc(int, int&, int&)
> const’:
> ../compat.h:465:21: error: ‘get_preferred_height_for_width_vfunc’ is not a
> member of ‘Gtk::Label’
>   465 |         Gtk::Label::get_preferred_height_for_width_vfunc(width,
> minimum_height, natural_height);
> 
>       |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> ../compat.h:474:14: error: ‘get_margin_top’ was not declared in this scope
>   474 |         h += get_margin_top() + get_margin_bottom();
> 
>       |              ^~~~~~~~~~~~~~
> 
> ../compat.h:474:33: error: ‘get_margin_bottom’ was not declared in this
> scope
>   474 |         h += get_margin_top() + get_margin_bottom();
> 
>       |                                 ^~~~~~~~~~~~~~~~~

Yeah, I just realized get_margin_top() and get_margin_bottom() were introduced 
with Gtk 3.0 and are not documented as such in the gtkmm docs. You are using 
Gtk 2 it seems. That code in question fixes a problem with Gtk(3?) that causes 
long multi-line text to take more vertical space than actually required.

I just commented this code out for Gtk 2 and older for now, as I don't see an 
obvious way to fix this more adequately for Gtk 2.

The only drawback is maybe that you get some graphical glitches on the 
relatively new "Script" tab on the very top right hand side of Gigedit's main 
window with Gtk 2. I currently don't have Gtk 2 installed anywhere, so I can't 
test this.

> make[4]: *** [Makefile:498: builtinpix.lo] Error 1
> 
> Got some deprecated warnings too, but not sure how relevant they are.
> 
> make[4]: Entering directory '/home/andrew/Downloads/gigedit/src/gigedit/gfx'
> CXX      builtinpix.lo
> In file included from /usr/include/gtk-2.0/gtk/gtkobject.h:37,
>                  from /usr/include/gtk-2.0/gtk/gtkwidget.h:36,
>                  from /usr/include/gtk-2.0/gtk/gtkcontainer.h:35,
>                  from /usr/include/gtk-2.0/gtk/gtkbin.h:35,
>                  from /usr/include/gtk-2.0/gtk/gtkwindow.h:36,
>                  from /usr/include/gtk-2.0/gtk/gtkdialog.h:35,
>                  from /usr/include/gtk-2.0/gtk/gtkaboutdialog.h:32,
>                  from /usr/include/gtk-2.0/gtk/gtk.h:33,
>                  from ../compat.h:26,
>                  from builtinpix.cpp:2:
> /usr/include/gtk-2.0/gtk/gtktypeutils.h:236:64: warning: ‘GTypeDebugFlags’
> is deprecated [-Wdeprecated-declarations]
>   236 | void            gtk_type_init   (GTypeDebugFlags    debug_flags);
> 
>       |                                                                ^
> 
> In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
>                  from /usr/include/glib-2.0/gobject/gbinding.h:29,
>                  from /usr/include/glib-2.0/glib-object.h:22,
>                  from /usr/include/glibmm-2.4/glibmm/class.h:24,
>                  from /usr/include/glibmm-2.4/glibmm/objectbase.h:21,
>                  from /usr/include/glibmm-2.4/glibmm/object.h:29,
>                  from /usr/include/pangomm-1.4/pangomm/font.h:31,
>                  from /usr/include/gdkmm-2.4/gdkmm/drawable.h:29,
>                  from /usr/include/gdkmm-2.4/gdkmm/pixbuf.h:33,
>                  from builtinpix.h:4,
>                  from builtinpix.cpp:1:
> /usr/include/glib-2.0/gobject/gtype.h:685:3: note: declared here
>   685 | } GTypeDebugFlags GLIB_DEPRECATED_TYPE_IN_2_36;
> 
>       |   ^~~~~~~~~~~~~~~
> 
> In file included from /usr/include/gtk-2.0/gtk/gtktoolitem.h:31,
>                  from /usr/include/gtk-2.0/gtk/gtktoolbutton.h:30,
>                  from /usr/include/gtk-2.0/gtk/gtkmenutoolbutton.h:30,
>                  from /usr/include/gtk-2.0/gtk/gtk.h:126,
>                  from ../compat.h:26,
>                  from builtinpix.cpp:2:
> /usr/include/gtk-2.0/gtk/gtktooltips.h:73:12: warning: ‘GTimeVal’ is
> deprecated: Use 'GDateTime' instead [-Wdeprecated-declarations]
>    73 |   GTimeVal last_popdown;
> 
>       |            ^~~~~~~~~~~~
> 
> In file included from /usr/include/glib-2.0/glib/galloca.h:32,
>                  from /usr/include/glib-2.0/glib.h:30,
>                  from /usr/include/glibmm-2.4/glibmm/unicode.h:23,
>                  from /usr/include/glibmm-2.4/glibmm/ustring.h:21,
>                  from /usr/include/gdkmm-2.4/gdkmm/pixbuf.h:9,
>                  from builtinpix.h:4,
>                  from builtinpix.cpp:1:
> /usr/include/glib-2.0/glib/gtypes.h:545:26: note: declared here
>   545 | typedef struct _GTimeVal GTimeVal
> GLIB_DEPRECATED_TYPE_IN_2_62_FOR(GDateTime);
> 
>       |                          ^~~~~~~~

These warnings are not our business. Basically they just say that your Gtk 2 
version uses things from Glib that were deprecated in Glib long ago. This is 
not something in Gigedit's code, but rather in Gtk 2's code, hence I can't fix 
them.

You might report them to Gtk or to your distro, but I am not sure whether Gtk 
2 is still maintained at all.

Now don't get me wrong: I am not saying you should upgrade to Gtk 3, because 
Gtk 2 is still much faster than Gtk 3 and the visual appearance will be 
completely different.

CU
Christian




_______________________________________________
Linuxsampler-devel mailing list
Linuxsampler-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel

Reply via email to