On Sunday, February 11, 2024 1:31:25 PM CET Christian Schoenebeck wrote: > On Sunday, February 11, 2024 8:56:59 AM CET Ross Maxx wrote: > > Hello again. I tried to build libgig 4.4.0 on MSVC and found a few build > > errors. > > > > 1. I had to define `ssize_t` again in `gig.h`, I previously did this in > > `serialization.h`. > > Well, it's probably time to move those fundamental type definitions and > system dependent defines into a separate, shared header file. Otherwise > we'll continue kicking the ball into other corners.
https://svn.linuxsampler.org/cgi-bin/viewvc.cgi?view=revision&revision=4093 > > 2. In `RIFF.h`, line 1972, there seems to be a C++ 20 specific syntax > > wrapped in an if `_MSC_VER`, which I fixed by forcing cmake to use C++ 20 > > for MSVC alone. > > It actually affects all systems. It uses so called designated initializers > like > > foo - { > .a = 1, > .b - 2, > }; > > That's a C++20 feature indeed. With some compilers it emits a warning, on > others an error. > > I'll change the code instead. Probably a bit too early to require C++20 at > this point yet. https://svn.linuxsampler.org/cgi-bin/viewvc.cgi?view=revision&revision=4092 I will roll out a new libgig release tarball soon. But I wait some more days to see whether there are more issues to fix. /Christian > > note : We use cmake 3.1 but there seems to be a deprecation warning for > > cmake < 3.5. Might as well note it. Not sending the patch for that one > > right now as it doesn't break compilation. _______________________________________________ Linuxsampler-devel mailing list Linuxsampler-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
