The patch number 8086 was added via Hans Verkuil <[EMAIL PROTECTED]>
to http://linuxtv.org/hg/v4l-dvb master development tree.

Kernel patches in this development tree may be modified to be backward
compatible with older kernels. Compatibility modifications will be
removed before inclusion into the mainstream Kernel

If anyone has any objections, please let us know by sending a message to:
        [EMAIL PROTECTED]

------

From: Hans Verkuil  <[EMAIL PROTECTED]>
ivtv/cx18: fix video_temporal_filter handling


If the capture is scaled, then the video_temporal_filter is set to 0
by the cx2341x.c module since otherwise you would get ghosting.

However, this was also done in the VIDIOC_S_FMT ioctl which meant that
the video_temporal_filter control was reset to 0 or 8 each time S_FMT
was called. This was old code that should have been removed a long time
ago.

Signed-off-by: Hans Verkuil <[EMAIL PROTECTED]>


---

 linux/drivers/media/video/cx18/cx18-ioctl.c |   11 -----------
 linux/drivers/media/video/ivtv/ivtv-ioctl.c |    9 ---------
 2 files changed, 20 deletions(-)

diff -r 1dd0bffaef18 -r ac01265082c0 linux/drivers/media/video/cx18/cx18-ioctl.c
--- a/linux/drivers/media/video/cx18/cx18-ioctl.c       Sat Jun 21 11:06:59 
2008 +0200
+++ b/linux/drivers/media/video/cx18/cx18-ioctl.c       Sat Jun 21 11:21:23 
2008 +0200
@@ -229,13 +229,6 @@ static int cx18_try_fmt_vid_cap(struct f
        cx18_g_fmt_vid_cap(file, fh, fmt);
        fmt->fmt.pix.width = w;
        fmt->fmt.pix.height = h;
-#if LINUX_VERSION_CODE <= KERNEL_VERSION(2, 6, 18)
-       if (cx->params.width != 720 ||
-                       cx->params.height != (cx->is_50hz ? 576 : 480))
-               cx->params.video_temporal_filter = 0;
-       else
-               cx->params.video_temporal_filter = 8;
-#endif
        return 0;
 }
 
@@ -299,10 +292,6 @@ static int cx18_s_fmt_vid_cap(struct fil
 
        cx->params.width = w;
        cx->params.height = h;
-       if (w != 720 || h != (cx->is_50hz ? 576 : 480))
-               cx->params.video_temporal_filter = 0;
-       else
-               cx->params.video_temporal_filter = 8;
        cx18_av_cmd(cx, VIDIOC_S_FMT, fmt);
        return cx18_g_fmt_vid_cap(file, fh, fmt);
 }
diff -r 1dd0bffaef18 -r ac01265082c0 linux/drivers/media/video/ivtv/ivtv-ioctl.c
--- a/linux/drivers/media/video/ivtv/ivtv-ioctl.c       Sat Jun 21 11:06:59 
2008 +0200
+++ b/linux/drivers/media/video/ivtv/ivtv-ioctl.c       Sat Jun 21 11:21:23 
2008 +0200
@@ -508,11 +508,6 @@ static int ivtv_try_fmt_vid_cap(struct f
        ivtv_g_fmt_vid_cap(file, fh, fmt);
        fmt->fmt.pix.width = w;
        fmt->fmt.pix.height = h;
-       if (itv->params.width != 720 ||
-                       itv->params.height != (itv->is_50hz ? 576 : 480))
-               itv->params.video_temporal_filter = 0;
-       else
-               itv->params.video_temporal_filter = 8;
        return 0;
 }
 
@@ -608,10 +603,6 @@ static int ivtv_s_fmt_vid_cap(struct fil
 
        p->width = w;
        p->height = h;
-       if (w != 720 || h != (itv->is_50hz ? 576 : 480))
-               p->video_temporal_filter = 0;
-       else
-               p->video_temporal_filter = 8;
        if (p->video_encoding == V4L2_MPEG_VIDEO_ENCODING_MPEG_1)
                fmt->fmt.pix.width /= 2;
        itv->video_dec_func(itv, VIDIOC_S_FMT, fmt);


---

Patch is available at: 
http://linuxtv.org/hg/v4l-dvb/rev/ac01265082c0120bfcf701238f2468aeb28a1543

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to