The patch number 8801 was added via Geert Uytterhoeven <[EMAIL PROTECTED]>
to http://linuxtv.org/hg/v4l-dvb master development tree.
Kernel patches in this development tree may be modified to be backward
compatible with older kernels. Compatibility modifications will be
removed before inclusion into the mainstream Kernel
If anyone has any objections, please let us know by sending a message to:
[EMAIL PROTECTED]
------
VIDEO_SH_MOBILE_CEU should depend on HAS_DMA (was: Re: m68k allmodconfig)
Hi Andrew,
On Thu, 14 Aug 2008, Andrew Morton wrote:
> ERROR: "dma_alloc_coherent" [drivers/media/video/videobuf-dma-contig.ko]
> undefined!
> ERROR: "dma_sync_single_for_cpu" [drivers/media/video/videobuf-dma-contig.ko]
> undefined!
> ERROR: "dma_free_coherent" [drivers/media/video/videobuf-dma-contig.ko]
> undefined!
M68k allmodconfig still selects Sun-3, which sets NO_DMA.
I guess you're also seeing this on the other NO_DMA platforms (h8300, m32r,
s390, and PCI-less SPARC)?
Below is a patch.
Shouldn't it also (or instead) depend on SUPERH or some SuperH platform?
Or is this not done to have more compile-coverage?
Subject: [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA
commit 0d3244d6439c8c31d2a29efd587c7aca9042c8aa ("V4L/DVB (8342):
sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3") introduced
VIDEO_SH_MOBILE_CEU, which selects VIDEOBUF_DMA_CONTIG. This circumvents the
dependency on HAS_DMA of VIDEOBUF_DMA_CONTIG.
Add a dependency on HAS_DMA to VIDEO_SH_MOBILE_CEU to fix this.
Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
Acked-by: Paul Mundt <[EMAIL PROTECTED]>
Acked-by: Magnus Damm <[EMAIL PROTECTED]>
Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]>
---
drivers/media/video/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
linux/drivers/media/video/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -r 734ef518c385 -r ee6d4f42fea8 linux/drivers/media/video/Kconfig
--- a/linux/drivers/media/video/Kconfig Wed Aug 27 22:20:01 2008 +0200
+++ b/linux/drivers/media/video/Kconfig Wed Aug 27 22:20:15 2008 +0200
@@ -822,7 +822,7 @@ config VIDEO_PXA27x
config VIDEO_SH_MOBILE_CEU
tristate "SuperH Mobile CEU Interface driver"
- depends on VIDEO_DEV && SOC_CAMERA
+ depends on VIDEO_DEV && SOC_CAMERA && HAS_DMA
select VIDEOBUF_DMA_CONTIG
---help---
This is a v4l2 driver for the SuperH Mobile CEU Interface
---
Patch is available at:
http://linuxtv.org/hg/v4l-dvb/rev/ee6d4f42fea8e7541b92d4d6fe178aef5ea940fd
_______________________________________________
linuxtv-commits mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits
