The patch number 8999 was added via Steven Toth <[EMAIL PROTECTED]>
to http://linuxtv.org/hg/v4l-dvb master development tree.
Kernel patches in this development tree may be modified to be backward
compatible with older kernels. Compatibility modifications will be
removed before inclusion into the mainstream Kernel
If anyone has any objections, please let us know by sending a message to:
[EMAIL PROTECTED]
------
From: Steven Toth <[EMAIL PROTECTED]>
S2API: Reduce demod driver complexity by using a cache sync
For demod drivers, we want a single tuning function (set_frontend) to have
access to the properly constructed dvb_frontend_parameters structure, or
the cache values - regardless of whether the legacy or new API is being used.
This cuts down on redundant code in the demod drivers and ensures the
tuning parameters are consistent regardless of the API entry type.
Priority: normal
Signed-off-by: Steven Toth <[EMAIL PROTECTED]>
---
linux/drivers/media/dvb/dvb-core/dvb_frontend.c | 38 ++++++++++++++++
1 file changed, 38 insertions(+)
diff -r 9c3754e2e8d5 -r d419c728169f
linux/drivers/media/dvb/dvb-core/dvb_frontend.c
--- a/linux/drivers/media/dvb/dvb-core/dvb_frontend.c Thu Sep 11 20:08:59
2008 -0400
+++ b/linux/drivers/media/dvb/dvb-core/dvb_frontend.c Thu Sep 11 22:52:32
2008 -0400
@@ -1002,6 +1002,42 @@ int is_legacy_delivery_system(fe_deliver
return 1;
return 0;
+}
+
+/* Synchronise the legacy tuning parameters into the cache, so that demodulator
+ * drivers can use a single set_frontend tuning function, regardless of whether
+ * it's being used for the legacy or new API, reducing code and complexity.
+ */
+void dtv_property_cache_sync(struct dvb_frontend *fe, struct
dvb_frontend_parameters *p)
+{
+ struct dtv_frontend_properties *c = &fe->dtv_property_cache;
+
+ c->frequency = p->frequency;
+ c->inversion = p->inversion;
+
+ switch (fe->ops.info.type) {
+ case FE_QPSK:
+ c->symbol_rate = p->u.qpsk.symbol_rate;
+ c->fec_inner = p->u.qpsk.fec_inner;
+ break;
+ case FE_QAM:
+ c->symbol_rate = p->u.qam.symbol_rate;
+ c->fec_inner = p->u.qam.fec_inner;
+ c->modulation = p->u.qam.modulation;
+ break;
+ case FE_OFDM:
+ c->bandwidth = p->u.ofdm.bandwidth;
+ c->code_rate_HP = p->u.ofdm.code_rate_HP;
+ c->code_rate_LP = p->u.ofdm.code_rate_LP;
+ c->modulation = p->u.ofdm.constellation;
+ c->transmission_mode = p->u.ofdm.transmission_mode;
+ c->guard_interval = p->u.ofdm.guard_interval;
+ c->hierarchy = p->u.ofdm.hierarchy_information;
+ break;
+ case FE_ATSC:
+ c->modulation = p->u.vsb.modulation;
+ break;
+ }
}
int dtv_property_cache_submit(struct dvb_frontend *fe)
@@ -1559,6 +1595,8 @@ static int dvb_frontend_ioctl_legacy(str
case FE_SET_FRONTEND: {
struct dvb_frontend_tune_settings fetunesettings;
+ dtv_property_cache_sync(fe, &fepriv->parameters);
+
if(fe->dtv_property_cache.state == DTV_TUNE) {
if (dvb_frontend_check_parameters(fe,
&fepriv->parameters) < 0) {
err = -EINVAL;
---
Patch is available at:
http://linuxtv.org/hg/v4l-dvb/rev/d419c728169f34879a8a5269228b04c9b78a9445
_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits
