The patch number 11261 was added via Trent Piepho <[email protected]>
to http://linuxtv.org/hg/v4l-dvb master development tree.

Kernel patches in this development tree may be modified to be backward
compatible with older kernels. Compatibility modifications will be
removed before inclusion into the mainstream Kernel

If anyone has any objections, please let us know by sending a message to:
        Linux Media Mailing List <[email protected]>

------

From: Trent Piepho  <[email protected]>
saa7146: Remove buffer type check from vidioc_g_parm


The v4l2-ioctl core now only allows buffer types for which the
corresponding ->vidioc_try_fmt_xxx() methods are defined to be used with
vidioc_(g|s)_parm.

The driver was only allowing VIDEO_CAPTURE buffers for g_parm, but since
the driver defines ->vidioc_try_fmt_vid_overlay() it will now allow
VIDEO_OVERLAY buffers as well.  This should be fine as the fields the
driver fills in, readbuffers and frame rate, aren't wrong for VIDEO_OVERLAY
buffers.

Priority: normal

Signed-off-by: Trent Piepho <[email protected]>


---

 linux/drivers/media/common/saa7146_video.c |    2 --
 1 file changed, 2 deletions(-)

diff -r 44632c5fe5b2 -r c879e8f8c32b linux/drivers/media/common/saa7146_video.c
--- a/linux/drivers/media/common/saa7146_video.c        Sat Mar 28 18:25:35 
2009 -0700
+++ b/linux/drivers/media/common/saa7146_video.c        Sat Mar 28 18:25:35 
2009 -0700
@@ -724,8 +724,6 @@ static int vidioc_g_parm(struct file *fi
        struct saa7146_dev *dev = ((struct saa7146_fh *)fh)->dev;
        struct saa7146_vv *vv = dev->vv_data;
 
-       if (parm->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
-               return -EINVAL;
        parm->parm.capture.readbuffers = 1;
        v4l2_video_std_frame_period(vv->standard->id,
                                    &parm->parm.capture.timeperframe);


---

Patch is available at: 
http://linuxtv.org/hg/v4l-dvb/rev/c879e8f8c32b9c6b30144bab983d4caa04830edb

_______________________________________________
linuxtv-commits mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to