The patch number 11563 was added via Mauro Carvalho Chehab <mche...@redhat.com>
to http://linuxtv.org/hg/v4l-dvb master development tree.

Kernel patches in this development tree may be modified to be backward
compatible with older kernels. Compatibility modifications will be
removed before inclusion into the mainstream Kernel

If anyone has any objections, please let us know by sending a message to:
        Linux Media Mailing List <linux-me...@vger.kernel.org>

------

From: Mauro Carvalho Chehab  <mche...@redhat.com>
revert changeset 11562:fd645c976997


The changeset created breakage on both modules:

WARNING: "sms_debug" [/home/v4l/master/v4l/smsusb.ko] undefined!
WARNING: "sms_debug" [/home/v4l/master/v4l/smsdvb.ko] undefined!

Signed-off-by: Mauro Carvalho Chehab <mche...@redhat.com>


---

 linux/drivers/media/dvb/siano/smscoreapi.c |    4 ++--
 linux/drivers/media/dvb/siano/smscoreapi.h |    3 +--
 linux/drivers/media/dvb/siano/smsdvb.c     |    3 +++
 3 files changed, 6 insertions(+), 4 deletions(-)

diff -r fd645c976997 -r 2a79c416fabd linux/drivers/media/dvb/siano/smscoreapi.c
--- a/linux/drivers/media/dvb/siano/smscoreapi.c        Sun Apr 05 10:25:06 
2009 +0000
+++ b/linux/drivers/media/dvb/siano/smscoreapi.c        Mon Apr 20 14:52:21 
2009 -0300
@@ -34,8 +34,8 @@
 #include "smscoreapi.h"
 #include "sms-cards.h"
 
-int sms_debug;
-module_param_named(debug, sms_debug, int, 0644);
+static int sms_dbg;
+module_param_named(debug, sms_dbg, int, 0644);
 MODULE_PARM_DESC(debug, "set debug level (info=1, adv=2 (or-able))");
 
 struct smscore_device_notifyee_t {
diff -r fd645c976997 -r 2a79c416fabd linux/drivers/media/dvb/siano/smscoreapi.h
--- a/linux/drivers/media/dvb/siano/smscoreapi.h        Sun Apr 05 10:25:06 
2009 +0000
+++ b/linux/drivers/media/dvb/siano/smscoreapi.h        Mon Apr 20 14:52:21 
2009 -0300
@@ -658,7 +658,6 @@ int smscore_led_state(struct smscore_dev
 
 
 /* ------------------------------------------------------------------------ */
-extern int sms_debug;
 
 #define DBG_INFO 1
 #define DBG_ADV  2
@@ -667,7 +666,7 @@ extern int sms_debug;
        printk(kern "%s: " fmt "\n", __func__, ##arg)
 
 #define dprintk(kern, lvl, fmt, arg...) do {\
-       if (sms_debug & lvl) \
+       if (sms_dbg & lvl) \
                sms_printk(kern, fmt, ##arg); } while (0)
 
 #define sms_log(fmt, arg...) sms_printk(KERN_INFO, fmt, ##arg)
diff -r fd645c976997 -r 2a79c416fabd linux/drivers/media/dvb/siano/smsdvb.c
--- a/linux/drivers/media/dvb/siano/smsdvb.c    Sun Apr 05 10:25:06 2009 +0000
+++ b/linux/drivers/media/dvb/siano/smsdvb.c    Mon Apr 20 14:52:21 2009 -0300
@@ -50,6 +50,9 @@ static struct list_head g_smsdvb_clients
 static struct list_head g_smsdvb_clients;
 static struct mutex g_smsdvb_clientslock;
 
+static int sms_dbg;
+module_param_named(debug, sms_dbg, int, 0644);
+MODULE_PARM_DESC(debug, "set debug level (info=1, adv=2 (or-able))");
 
 static int smsdvb_onresponse(void *context, struct smscore_buffer_t *cb)
 {


---

Patch is available at: 
http://linuxtv.org/hg/v4l-dvb/rev/2a79c416fabd322e5dfd2a70dc5b72a55e9fe733

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to