The patch number 14199 was added via Douglas Schilling Landgraf
<[email protected]>
to http://linuxtv.org/hg/v4l-dvb master development tree.
Kernel patches in this development tree may be modified to be backward
compatible with older kernels. Compatibility modifications will be
removed before inclusion into the mainstream Kernel
If anyone has any objections, please let us know by sending a message to:
Linux Media Mailing List <[email protected]>
------
From: Martin Fuzzey <[email protected]>
pwc: Fix regression in pwc_set_shutter_speed caused by bad constant => sizeof
conversion.
Regression was caused by my commit 6b35ca0d3d586b8ecb8396821af21186e20afaf0
which determined message size using sizeof rather than hardcoded constants.
Unfortunately pwc_set_shutter_speed reuses a 2 byte buffer for a one byte
message too so the sizeof was bogus in this case.
All other uses of sizeof checked and are ok.
Priority: normal
Acked-by: Laurent Pinchart <[email protected]>
Signed-off-by: Martin Fuzzey <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
Signed-off-by: Douglas Schilling Landgraf <[email protected]>
---
linux/drivers/media/video/pwc/pwc-ctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -r 14021dfc00f3 -r 3abc5b760760 linux/drivers/media/video/pwc/pwc-ctrl.c
--- a/linux/drivers/media/video/pwc/pwc-ctrl.c Thu Feb 11 23:11:30 2010 -0200
+++ b/linux/drivers/media/video/pwc/pwc-ctrl.c Thu Feb 18 20:08:23 2010 -0200
@@ -753,7 +753,7 @@
buf[0] = 0xff; /* fixed */
ret = send_control_msg(pdev,
- SET_LUM_CTL, SHUTTER_MODE_FORMATTER, &buf, sizeof(buf));
+ SET_LUM_CTL, SHUTTER_MODE_FORMATTER, &buf, 1);
if (!mode && ret >= 0) {
if (value < 0)
---
Patch is available at:
http://linuxtv.org/hg/v4l-dvb/rev/3abc5b760760bada83199ff23cf624d8b3e18af7
_______________________________________________
linuxtv-commits mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits
