This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/v4l-dvb.git tree:

Subject: V4L/DVB: drivers/media/video: avoid NULL dereference
Author:  Julia Lawall <[email protected]>
Date:    Tue Apr 6 02:51:04 2010 -0300

It seems impossible for ov to be NULL at this point.

The semantic match that finds the problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression E, E1;
identifier f;
statement S1,S3;
iterator iter;
@@

if ((E == NULL && ...) || ...)
{
  ... when != false ((E == NULL && ...) || ...)
      when != true  ((E != NULL && ...) || ...)
      when != iter(E,...) S1
      when != E = E1
(
  sizeof(E->f)
|
* E->f
)
  ... when any
  return ...;
}
else S3
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Douglas Schilling Landgraf <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/media/video/ov511.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

---

http://git.linuxtv.org/v4l-dvb.git?a=commitdiff;h=2e2621b073c14eee5ea28cf2a6286cefcd5c318d

diff --git a/drivers/media/video/ov511.c b/drivers/media/video/ov511.c
index e0bce8d..dd1b1ac 100644
--- a/drivers/media/video/ov511.c
+++ b/drivers/media/video/ov511.c
@@ -5916,11 +5916,6 @@ ov51x_disconnect(struct usb_interface *intf)
        mutex_lock(&ov->lock);
        usb_set_intfdata (intf, NULL);
 
-       if (!ov) {
-               mutex_unlock(&ov->lock);
-               return;
-       }
-
        /* Free device number */
        ov511_devused &= ~(1 << ov->nr);
 

_______________________________________________
linuxtv-commits mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to