This is an automatic generated email to let you know that the following patch were queued at the http://git.linuxtv.org/v4l-utils.git tree:
Subject: autogain.c: run through checkpatch.pl Author: Hans Verkuil <hverk...@xs4all.nl> Date: Fri Apr 30 08:25:26 2010 +0200 Signed-off-by: Hans Verkuil <hverk...@xs4all.nl> lib/libv4lconvert/processing/autogain.c | 316 ++++++++++++++++--------------- 1 files changed, 159 insertions(+), 157 deletions(-) --- http://git.linuxtv.org/v4l-utils.git?a=commitdiff;h=0fb7d3f7d6a1cb9b65fae6b8d15fc485baec1722 diff --git a/lib/libv4lconvert/processing/autogain.c b/lib/libv4lconvert/processing/autogain.c index 5978bb8..3a00b6d 100644 --- a/lib/libv4lconvert/processing/autogain.c +++ b/lib/libv4lconvert/processing/autogain.c @@ -14,7 +14,7 @@ # You should have received a copy of the GNU Lesser General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -*/ + */ #include <errno.h> #include <string.h> @@ -27,176 +27,178 @@ #include "../libv4lconvert-priv.h" /* for PIX_FMT defines */ #include "../libv4lsyscall-priv.h" -static int autogain_active(struct v4lprocessing_data *data) { - int autogain; +static int autogain_active(struct v4lprocessing_data *data) +{ + int autogain; - autogain = v4lcontrol_get_ctrl(data->control, V4LCONTROL_AUTOGAIN); - if (!autogain) { - /* Reset last_correction val */ - data->last_gain_correction = 0; - } + autogain = v4lcontrol_get_ctrl(data->control, V4LCONTROL_AUTOGAIN); + if (!autogain) { + /* Reset last_correction val */ + data->last_gain_correction = 0; + } - return autogain; + return autogain; } /* Adjust ctrl value with steps steps, while not crossing limit */ static void autogain_adjust(struct v4l2_queryctrl *ctrl, int *value, - int steps, int limit) + int steps, int limit) { - int ctrl_range = (ctrl->maximum - ctrl->minimum) / ctrl->step; - - /* If we are of 3 * deadzone or more, and we have a very fine grained - control, take larger steps, otherwise we take ages to get to the - right setting point. We use 256 as tripping point for determineing fine - grained controls here, as avg_lum has a range of 0 - 255. */ - if (abs(steps) >= 3 && ctrl_range > 256) - *value += steps * ctrl->step * (ctrl_range / 256); - else - *value += steps * ctrl->step; - - if (steps > 0) { - if (*value > limit) - *value = limit; - } else { - if (*value < limit) - *value = limit; - } + int ctrl_range = (ctrl->maximum - ctrl->minimum) / ctrl->step; + + /* If we are of 3 * deadzone or more, and we have a very fine grained + control, take larger steps, otherwise we take ages to get to the + right setting point. We use 256 as tripping point for determineing fine + grained controls here, as avg_lum has a range of 0 - 255. */ + if (abs(steps) >= 3 && ctrl_range > 256) + *value += steps * ctrl->step * (ctrl_range / 256); + else + *value += steps * ctrl->step; + + if (steps > 0) { + if (*value > limit) + *value = limit; + } else { + if (*value < limit) + *value = limit; + } } /* auto gain and exposure algorithm based on the knee algorithm described here: - http://ytse.tricolour.net/docs/LowLightOptimization.html */ +http://ytse.tricolour.net/docs/LowLightOptimization.html */ static int autogain_calculate_lookup_tables( - struct v4lprocessing_data *data, - unsigned char *buf, const struct v4l2_format *fmt) + struct v4lprocessing_data *data, + unsigned char *buf, const struct v4l2_format *fmt) { - int x, y, target, steps, avg_lum = 0; - int gain, exposure, orig_gain, orig_exposure, exposure_low; - struct v4l2_control ctrl; - struct v4l2_queryctrl gainctrl, expoctrl; - const int deadzone = 6; - - ctrl.id = V4L2_CID_EXPOSURE; - expoctrl.id = V4L2_CID_EXPOSURE; - if (SYS_IOCTL(data->fd, VIDIOC_QUERYCTRL, &expoctrl) || - SYS_IOCTL(data->fd, VIDIOC_G_CTRL, &ctrl)) - return 0; - exposure = orig_exposure = ctrl.value; - /* Determine a value below which we try to not lower the exposure, - as most exposure controls tend to jump with big steps in the low - range, causing oscilation, so we prefer to use gain when exposure - has hit this value */ - exposure_low = expoctrl.maximum / 10; - /* If we have a fine grained exposure control only avoid the last 10 steps */ - steps = exposure_low / expoctrl.step; - if (steps > 10) - steps = 10; - exposure_low = steps * expoctrl.step + expoctrl.minimum; - - ctrl.id = V4L2_CID_GAIN; - gainctrl.id = V4L2_CID_GAIN; - if (SYS_IOCTL(data->fd, VIDIOC_QUERYCTRL, &gainctrl) || - SYS_IOCTL(data->fd, VIDIOC_G_CTRL, &ctrl)) - return 0; - gain = orig_gain = ctrl.value; - - switch (fmt->fmt.pix.pixelformat) { - case V4L2_PIX_FMT_SGBRG8: - case V4L2_PIX_FMT_SGRBG8: - case V4L2_PIX_FMT_SBGGR8: - case V4L2_PIX_FMT_SRGGB8: - buf += fmt->fmt.pix.height * fmt->fmt.pix.bytesperline / 4 + - fmt->fmt.pix.width / 4; - - for (y = 0; y < fmt->fmt.pix.height / 2; y++) { - for (x = 0; x < fmt->fmt.pix.width / 2; x++) { - avg_lum += *buf++; + int x, y, target, steps, avg_lum = 0; + int gain, exposure, orig_gain, orig_exposure, exposure_low; + struct v4l2_control ctrl; + struct v4l2_queryctrl gainctrl, expoctrl; + const int deadzone = 6; + + ctrl.id = V4L2_CID_EXPOSURE; + expoctrl.id = V4L2_CID_EXPOSURE; + if (SYS_IOCTL(data->fd, VIDIOC_QUERYCTRL, &expoctrl) || + SYS_IOCTL(data->fd, VIDIOC_G_CTRL, &ctrl)) + return 0; + + exposure = orig_exposure = ctrl.value; + /* Determine a value below which we try to not lower the exposure, + as most exposure controls tend to jump with big steps in the low + range, causing oscilation, so we prefer to use gain when exposure + has hit this value */ + exposure_low = expoctrl.maximum / 10; + /* If we have a fine grained exposure control only avoid the last 10 steps */ + steps = exposure_low / expoctrl.step; + if (steps > 10) + steps = 10; + exposure_low = steps * expoctrl.step + expoctrl.minimum; + + ctrl.id = V4L2_CID_GAIN; + gainctrl.id = V4L2_CID_GAIN; + if (SYS_IOCTL(data->fd, VIDIOC_QUERYCTRL, &gainctrl) || + SYS_IOCTL(data->fd, VIDIOC_G_CTRL, &ctrl)) + return 0; + gain = orig_gain = ctrl.value; + + switch (fmt->fmt.pix.pixelformat) { + case V4L2_PIX_FMT_SGBRG8: + case V4L2_PIX_FMT_SGRBG8: + case V4L2_PIX_FMT_SBGGR8: + case V4L2_PIX_FMT_SRGGB8: + buf += fmt->fmt.pix.height * fmt->fmt.pix.bytesperline / 4 + + fmt->fmt.pix.width / 4; + + for (y = 0; y < fmt->fmt.pix.height / 2; y++) { + for (x = 0; x < fmt->fmt.pix.width / 2; x++) + avg_lum += *buf++; + buf += fmt->fmt.pix.bytesperline - fmt->fmt.pix.width / 2; + } + avg_lum /= fmt->fmt.pix.height * fmt->fmt.pix.width / 4; + break; + + case V4L2_PIX_FMT_RGB24: + case V4L2_PIX_FMT_BGR24: + buf += fmt->fmt.pix.height * fmt->fmt.pix.bytesperline / 4 + + fmt->fmt.pix.width * 3 / 4; + + for (y = 0; y < fmt->fmt.pix.height / 2; y++) { + for (x = 0; x < fmt->fmt.pix.width / 2; x++) { + avg_lum += *buf++; + avg_lum += *buf++; + avg_lum += *buf++; + } + buf += fmt->fmt.pix.bytesperline - fmt->fmt.pix.width * 3 / 2; + } + avg_lum /= fmt->fmt.pix.height * fmt->fmt.pix.width * 3 / 4; + break; + } + + /* If we are off a multiple of deadzone, do multiple steps to reach the + desired lumination fast (with the risc of a slight overshoot) */ + target = v4lcontrol_get_ctrl(data->control, V4LCONTROL_AUTOGAIN_TARGET); + steps = (target - avg_lum) / deadzone; + + /* If we were decreasing and are now increasing, or vica versa, half the + number of steps to avoid overshooting and oscilating */ + if ((steps > 0 && data->last_gain_correction < 0) || + (steps < 0 && data->last_gain_correction > 0)) + steps /= 2; + + if (steps == 0) + return 0; /* Nothing to do */ + + if (steps < 0) { + if (exposure > expoctrl.default_value) + autogain_adjust(&expoctrl, &exposure, steps, expoctrl.default_value); + else if (gain > gainctrl.default_value) + autogain_adjust(&gainctrl, &gain, steps, gainctrl.default_value); + else if (exposure > exposure_low) + autogain_adjust(&expoctrl, &exposure, steps, exposure_low); + else if (gain > gainctrl.minimum) + autogain_adjust(&gainctrl, &gain, steps, gainctrl.minimum); + else if (exposure > expoctrl.minimum) + autogain_adjust(&expoctrl, &exposure, steps, expoctrl.minimum); + else + steps = 0; + } else { + if (exposure < exposure_low) + autogain_adjust(&expoctrl, &exposure, steps, exposure_low); + else if (gain < gainctrl.default_value) + autogain_adjust(&gainctrl, &gain, steps, gainctrl.default_value); + else if (exposure < expoctrl.default_value) + autogain_adjust(&expoctrl, &exposure, steps, expoctrl.default_value); + else if (gain < gainctrl.maximum) + autogain_adjust(&gainctrl, &gain, steps, gainctrl.maximum); + else if (exposure < expoctrl.maximum) + autogain_adjust(&expoctrl, &exposure, steps, expoctrl.maximum); + else + steps = 0; } - buf += fmt->fmt.pix.bytesperline - fmt->fmt.pix.width / 2; - } - avg_lum /= fmt->fmt.pix.height * fmt->fmt.pix.width / 4; - break; - - case V4L2_PIX_FMT_RGB24: - case V4L2_PIX_FMT_BGR24: - buf += fmt->fmt.pix.height * fmt->fmt.pix.bytesperline / 4 + - fmt->fmt.pix.width * 3 / 4; - - for (y = 0; y < fmt->fmt.pix.height / 2; y++) { - for (x = 0; x < fmt->fmt.pix.width / 2; x++) { - avg_lum += *buf++; - avg_lum += *buf++; - avg_lum += *buf++; + + if (steps) { + data->last_gain_correction = steps; + /* We are still settling down, force the next update sooner. Note we + skip the next frame as that is still captured with the old settings, + and another one just to be sure (because if we re-adjust based + on the old settings we might overshoot). */ + data->lookup_table_update_counter = V4L2PROCESSING_UPDATE_RATE - 2; + } + + if (gain != orig_gain) { + ctrl.id = V4L2_CID_GAIN; + ctrl.value = gain; + SYS_IOCTL(data->fd, VIDIOC_S_CTRL, &ctrl); } - buf += fmt->fmt.pix.bytesperline - fmt->fmt.pix.width * 3 / 2; - } - avg_lum /= fmt->fmt.pix.height * fmt->fmt.pix.width * 3 / 4; - break; - } - - /* If we are off a multiple of deadzone, do multiple steps to reach the - desired lumination fast (with the risc of a slight overshoot) */ - target = v4lcontrol_get_ctrl(data->control, V4LCONTROL_AUTOGAIN_TARGET); - steps = (target - avg_lum) / deadzone; - - /* If we were decreasing and are now increasing, or vica versa, half the - number of steps to avoid overshooting and oscilating */ - if ((steps > 0 && data->last_gain_correction < 0) || - (steps < 0 && data->last_gain_correction > 0)) - steps /= 2; - - if (steps == 0) - return 0; /* Nothing to do */ - - if (steps < 0) { - if (exposure > expoctrl.default_value) - autogain_adjust(&expoctrl, &exposure, steps, expoctrl.default_value); - else if (gain > gainctrl.default_value) - autogain_adjust(&gainctrl, &gain, steps, gainctrl.default_value); - else if (exposure > exposure_low) - autogain_adjust(&expoctrl, &exposure, steps, exposure_low); - else if (gain > gainctrl.minimum) - autogain_adjust(&gainctrl, &gain, steps, gainctrl.minimum); - else if (exposure > expoctrl.minimum) - autogain_adjust(&expoctrl, &exposure, steps, expoctrl.minimum); - else - steps = 0; - } else { - if (exposure < exposure_low) - autogain_adjust(&expoctrl, &exposure, steps, exposure_low); - else if (gain < gainctrl.default_value) - autogain_adjust(&gainctrl, &gain, steps, gainctrl.default_value); - else if (exposure < expoctrl.default_value) - autogain_adjust(&expoctrl, &exposure, steps, expoctrl.default_value); - else if (gain < gainctrl.maximum) - autogain_adjust(&gainctrl, &gain, steps, gainctrl.maximum); - else if (exposure < expoctrl.maximum) - autogain_adjust(&expoctrl, &exposure, steps, expoctrl.maximum); - else - steps = 0; - } - - if (steps) { - data->last_gain_correction = steps; - /* We are still settling down, force the next update sooner. Note we - skip the next frame as that is still captured with the old settings, - and another one just to be sure (because if we re-adjust based - on the old settings we might overshoot). */ - data->lookup_table_update_counter = V4L2PROCESSING_UPDATE_RATE - 2; - } - - if (gain != orig_gain) { - ctrl.id = V4L2_CID_GAIN; - ctrl.value = gain; - SYS_IOCTL(data->fd, VIDIOC_S_CTRL, &ctrl); - } - if (exposure != orig_exposure) { - ctrl.id = V4L2_CID_EXPOSURE; - ctrl.value = exposure; - SYS_IOCTL(data->fd, VIDIOC_S_CTRL, &ctrl); - } - - return 0; + if (exposure != orig_exposure) { + ctrl.id = V4L2_CID_EXPOSURE; + ctrl.value = exposure; + SYS_IOCTL(data->fd, VIDIOC_S_CTRL, &ctrl); + } + + return 0; } struct v4lprocessing_filter autogain_filter = { - autogain_active, autogain_calculate_lookup_tables }; + autogain_active, autogain_calculate_lookup_tables +}; _______________________________________________ linuxtv-commits mailing list linuxtv-commits@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits
