This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/media_tree.git tree:

Subject: [media] ati_remote: fix check for a weird byte
Author:  Anssi Hannula <[email protected]>
Date:    Sat Aug 6 18:18:10 2011 -0300

The ati_remote_dump() function tries to not print "Weird byte" warning
for 1-byte responses that contain 0xff or 0x00, but it doesn't work
properly as it simply falls back to the "Weird data" warning in the else
clause.

Fix that by adding an inner if clause.

Signed-off-by: Anssi Hannula <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/media/rc/ati_remote.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

---

http://git.linuxtv.org/media_tree.git?a=commitdiff;h=0224e0401f0b18e1f5fce010558b12fc24257e37

diff --git a/drivers/media/rc/ati_remote.c b/drivers/media/rc/ati_remote.c
index 7a47d7e..92f2b1b 100644
--- a/drivers/media/rc/ati_remote.c
+++ b/drivers/media/rc/ati_remote.c
@@ -273,9 +273,10 @@ static struct usb_driver ati_remote_driver = {
 static void ati_remote_dump(struct device *dev, unsigned char *data,
                            unsigned int len)
 {
-       if ((len == 1) && (data[0] != (unsigned char)0xff) && (data[0] != 0x00))
-               dev_warn(dev, "Weird byte 0x%02x\n", data[0]);
-       else if (len == 4)
+       if (len == 1) {
+               if (data[0] != (unsigned char)0xff && data[0] != 0x00)
+                       dev_warn(dev, "Weird byte 0x%02x\n", data[0]);
+       } else if (len == 4)
                dev_warn(dev, "Weird key %02x %02x %02x %02x\n",
                     data[0], data[1], data[2], data[3]);
        else

_______________________________________________
linuxtv-commits mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to