This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/media_tree.git tree:

Subject: [media] solo6x10: disable the 'priv' abuse
Author:  Hans Verkuil <[email protected]>
Date:    Fri Mar 15 16:35:28 2013 -0300

Signed-off-by: Hans Verkuil <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/staging/media/solo6x10/v4l2-enc.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

---

http://git.linuxtv.org/media_tree.git?a=commitdiff;h=69996873478d75381d14abbc9e768cc38d82e94b

diff --git a/drivers/staging/media/solo6x10/v4l2-enc.c 
b/drivers/staging/media/solo6x10/v4l2-enc.c
index 4fbfb35..0efb623 100644
--- a/drivers/staging/media/solo6x10/v4l2-enc.c
+++ b/drivers/staging/media/solo6x10/v4l2-enc.c
@@ -860,8 +860,16 @@ static int solo_enc_set_fmt_cap(struct file *file, void 
*priv,
        /* This does not change the encoder at all */
        solo_enc->fmt = pix->pixelformat;
 
+       /*
+        * More information is needed about these 'extended' types. As far
+        * as I can tell these are basically additional video streams with
+        * different MPEG encoding attributes that can run in parallel with
+        * the main stream. If so, then this should be implemented as a
+        * second video node. Abusing priv like this is certainly not the
+        * right approach.
        if (pix->priv)
                solo_enc->type = SOLO_ENC_TYPE_EXT;
+        */
        return 0;
 }
 

_______________________________________________
linuxtv-commits mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to