This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/media_tree.git tree:

Subject: [media] smiapp: Fix determining the need for 8-bit read access
Author:  Sakari Ailus <[email protected]>
Date:    Sat Apr 12 16:41:12 2014 -0300

8-bit reads are needed in some cases; however the condition used was wrong.
Regular access (register width) was used if:

        len == SMIAPP_REG_8BIT && !only8

This causes 8-bit read access to be used always. The operator should be ||
instead: regular access can be used for 8-bit reads OR if allowed otherwise.

Signed-off-by: Sakari Ailus <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/media/i2c/smiapp/smiapp-regs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

---

http://git.linuxtv.org/media_tree.git?a=commitdiff;h=b05cd219ec200c1c91d59011f8692d9b1c166fbc

diff --git a/drivers/media/i2c/smiapp/smiapp-regs.c 
b/drivers/media/i2c/smiapp/smiapp-regs.c
index 5d0151a..c2db205 100644
--- a/drivers/media/i2c/smiapp/smiapp-regs.c
+++ b/drivers/media/i2c/smiapp/smiapp-regs.c
@@ -172,7 +172,7 @@ static int __smiapp_read(struct smiapp_sensor *sensor, u32 
reg, u32 *val,
            && len != SMIAPP_REG_32BIT)
                return -EINVAL;
 
-       if (len == SMIAPP_REG_8BIT && !only8)
+       if (len == SMIAPP_REG_8BIT || !only8)
                rval = ____smiapp_read(sensor, (u16)reg, len, val);
        else
                rval = ____smiapp_read_8only(sensor, (u16)reg, len, val);

_______________________________________________
linuxtv-commits mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to