This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/media_tree.git tree:

Subject: [media] exynos4-is: fix error handling of irq_of_parse_and_map
Author:  Dmitry Torokhov <d...@chromium.org>
Date:    Fri Nov 14 19:09:50 2014 -0300

Return value of irq_of_parse_and_map() is unsigned int, with 0
indicating failure, so testing for negative result never works.

Signed-off-by: Dmitry Torokhov <d...@chromium.org>
Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com>

 drivers/media/platform/exynos4-is/fimc-is.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

---

http://git.linuxtv.org/media_tree.git?a=commitdiff;h=9a7a848df1995f05f750b4ed491ac80a459c912f

diff --git a/drivers/media/platform/exynos4-is/fimc-is.c 
b/drivers/media/platform/exynos4-is/fimc-is.c
index 22162b2..3d49ce0 100644
--- a/drivers/media/platform/exynos4-is/fimc-is.c
+++ b/drivers/media/platform/exynos4-is/fimc-is.c
@@ -814,9 +814,9 @@ static int fimc_is_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        is->irq = irq_of_parse_and_map(dev->of_node, 0);
-       if (is->irq < 0) {
+       if (!is->irq) {
                dev_err(dev, "no irq found\n");
-               return is->irq;
+               return -EINVAL;
        }
 
        ret = fimc_is_get_clocks(is);

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to