This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/cgit.cgi/media_tree.git tree:

Subject: [media] v4l: mt9v032: Consider control initialization errors as fatal
Author:  Laurent Pinchart <[email protected]>
Date:    Wed Jan 1 14:40:35 2014 -0300

The device requires control to be properly operated, they're not
optional.

Signed-off-by: Laurent Pinchart <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/media/i2c/mt9v032.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

---

http://git.linuxtv.org/cgit.cgi/media_tree.git/commit/?id=2d01209fd2d96cb9cd07b5c353efc47b525d71dc

diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c
index 3793d31..6d64e23 100644
--- a/drivers/media/i2c/mt9v032.c
+++ b/drivers/media/i2c/mt9v032.c
@@ -961,9 +961,12 @@ static int mt9v032_probe(struct i2c_client *client,
 
        mt9v032->subdev.ctrl_handler = &mt9v032->ctrls;
 
-       if (mt9v032->ctrls.error)
-               printk(KERN_INFO "%s: control initialization error %d\n",
-                      __func__, mt9v032->ctrls.error);
+       if (mt9v032->ctrls.error) {
+               dev_err(&client->dev, "control initialization error %d\n",
+                       mt9v032->ctrls.error);
+               ret = mt9v032->ctrls.error;
+               goto err;
+       }
 
        mt9v032->crop.left = MT9V032_COLUMN_START_DEF;
        mt9v032->crop.top = MT9V032_ROW_START_DEF;

_______________________________________________
linuxtv-commits mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to