This is an automatic generated email to let you know that the following patch were queued at the http://git.linuxtv.org/cgit.cgi/media_tree.git tree:
Subject: [media] si2165: Fix possible leak in si2165_upload_firmware() Author: Christian Engelmayer <[email protected]> Date: Wed Feb 11 17:58:23 2015 -0300 In case of an error function si2165_upload_firmware() releases the already requested firmware in the exit path. However, there is one deviation where the function directly returns. Use the correct cleanup so that the firmware memory gets freed correctly. Detected by Coverity CID 1269120. Signed-off-by: Christian Engelmayer <[email protected]> Signed-off-by: Matthias Schwarzott <[email protected]> Reviewed-by: Luis de Bethencourt <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]> drivers/media/dvb-frontends/si2165.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) --- http://git.linuxtv.org/cgit.cgi/media_tree.git/commit/?id=ec73b9fdc7c4fe3da8937a8e7b6a03a1e002d6ac diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c index 98ddb49..4cc5d10 100644 --- a/drivers/media/dvb-frontends/si2165.c +++ b/drivers/media/dvb-frontends/si2165.c @@ -505,7 +505,7 @@ static int si2165_upload_firmware(struct si2165_state *state) /* reset crc */ ret = si2165_writereg8(state, 0x0379, 0x01); if (ret) - return ret; + goto error; ret = si2165_upload_firmware_block(state, data, len, &offset, block_count); _______________________________________________ linuxtv-commits mailing list [email protected] http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits
