This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/cgit.cgi/media_tree.git tree:

Subject: [media] ivtv: fix incorrect audio mode report in log_status
Author:  Hans Verkuil <[email protected]>
Date:    Mon May 18 10:29:17 2015 -0300

The log_status ioctl should report if the audio input has mode Bilingual. 
However, the
check against the itv->dualwatch_stereo_mode is completely wrong and is a 
left-over from
the distant past. Not only is the bitmask obviously wrong, the test itself is 
broken too
since itv->dualwatch_stereo_mode is no longer a bitmask at all.

Fix this code properly.

Signed-off-by: Hans Verkuil <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/media/pci/ivtv/ivtv-ioctl.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

---

http://git.linuxtv.org/cgit.cgi/media_tree.git/commit/?id=3725d53149e190c6d8da80d458795a396705010e

diff --git a/drivers/media/pci/ivtv/ivtv-ioctl.c 
b/drivers/media/pci/ivtv/ivtv-ioctl.c
index 10c31cd..9a21c17 100644
--- a/drivers/media/pci/ivtv/ivtv-ioctl.c
+++ b/drivers/media/pci/ivtv/ivtv-ioctl.c
@@ -1531,7 +1531,8 @@ static int ivtv_log_status(struct file *file, void *fh)
        ivtv_get_audio_input(itv, itv->audio_input, &audin);
        IVTV_INFO("Video Input:  %s\n", vidin.name);
        IVTV_INFO("Audio Input:  %s%s\n", audin.name,
-               (itv->dualwatch_stereo_mode & ~0x300) == 0x200 ? " (Bilingual)" 
: "");
+               itv->dualwatch_stereo_mode == V4L2_MPEG_AUDIO_MODE_DUAL ?
+                       " (Bilingual)" : "");
        if (has_output) {
                struct v4l2_output vidout;
                struct v4l2_audioout audout;

_______________________________________________
linuxtv-commits mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to