This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/cgit.cgi/v4l-utils.git tree:

Subject: v4l2-dbg: auto-increment should use register size
Author:  Hans Verkuil <[email protected]>
Date:    Thu Sep 10 16:27:09 2015 +0200

When writing consecutive registers the register address should be
incremented by the register size, or, if absent, by the stride
setting.

Currently it is always 1, which does the wrong thing when dealing
with registers of size 4.

Signed-off-by: Hans Verkuil <[email protected]>

 utils/v4l2-dbg/v4l2-dbg.cpp |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

---

http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=f76d0c749b0c312bf3ee8a9ddd226b20233bbcd9

diff --git a/utils/v4l2-dbg/v4l2-dbg.cpp b/utils/v4l2-dbg/v4l2-dbg.cpp
index 981ee29..35a24c6 100644
--- a/utils/v4l2-dbg/v4l2-dbg.cpp
+++ b/utils/v4l2-dbg/v4l2-dbg.cpp
@@ -574,6 +574,12 @@ int main(int argc, char **argv)
                        usage();
                set_reg.reg = parse_reg(curr_bd, reg_set_arg);
                while (optind < argc) {
+                       unsigned size = 0;
+
+                       if (doioctl(fd, VIDIOC_DBG_G_REGISTER, &set_reg,
+                                   "VIDIOC_DBG_G_REGISTER") >= 0)
+                               size = set_reg.size;
+
                        set_reg.val = strtoull(argv[optind++], NULL, 0);
                        if (doioctl(fd, VIDIOC_DBG_S_REGISTER, &set_reg,
                                                "VIDIOC_DBG_S_REGISTER") >= 0) {
@@ -591,7 +597,7 @@ int main(int argc, char **argv)
                                printf("Failed to set register 0x%08llx value 
0x%llx: %s\n",
                                        set_reg.reg, set_reg.val, 
strerror(errno));
                        }
-                       set_reg.reg++;
+                       set_reg.reg += size ? : (forcedstride ? : 1);
                }
        }
 

_______________________________________________
linuxtv-commits mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to