This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/cgit.cgi/v4l-utils.git tree:

Subject: cec-compliance: add test broadcast unknown message
Author:  Hans Verkuil <[email protected]>
Date:    Wed Feb 15 15:01:09 2017 +0100

If an unknown message is broadcast, then it should be ignored by the
receiver(s). Check that it isn't replied to with a Feature Abort message.

Signed-off-by: Hans Verkuil <[email protected]>

 utils/cec-compliance/cec-test.cpp | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

---

http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=0065530b2f4f1625281381a996e8552c3ad264bc
diff --git a/utils/cec-compliance/cec-test.cpp 
b/utils/cec-compliance/cec-test.cpp
index 469ba417d71e..3d78bfd1b318 100644
--- a/utils/cec-compliance/cec-test.cpp
+++ b/utils/cec-compliance/cec-test.cpp
@@ -195,6 +195,7 @@ static struct remote_subtest system_info_subtests[] = {
 static int core_unknown(struct node *node, unsigned me, unsigned la, bool 
interactive)
 {
        struct cec_msg msg = { };
+       const __u8 unknown_opcode = 0xfe;
 
        /* Unknown opcodes should be responded to with Feature Abort, with abort
           reason Unknown Opcode.
@@ -203,7 +204,7 @@ static int core_unknown(struct node *node, unsigned me, 
unsigned la, bool intera
           needs to be updated for future CEC versions. */
        cec_msg_init(&msg, me, la);
        msg.len = 2;
-       msg.msg[1] = 0xfe;
+       msg.msg[1] = unknown_opcode;
        fail_on_test(!transmit_timeout(node, &msg));
        fail_on_test(timed_out(&msg));
        fail_on_test(!cec_msg_status_is_abort(&msg));
@@ -213,6 +214,14 @@ static int core_unknown(struct node *node, unsigned me, 
unsigned la, bool intera
        cec_ops_feature_abort(&msg, &abort_msg, &reason);
        fail_on_test(reason != CEC_OP_ABORT_UNRECOGNIZED_OP);
        fail_on_test(abort_msg != 0xfe);
+
+       /* Unknown opcodes that are broadcast should be ignored */
+       cec_msg_init(&msg, me, CEC_LOG_ADDR_BROADCAST);
+       msg.len = 2;
+       msg.msg[1] = unknown_opcode;
+       fail_on_test(!transmit_timeout(node, &msg));
+       fail_on_test(!timed_out(&msg));
+
        return 0;
 }
 

_______________________________________________
linuxtv-commits mailing list
[email protected]
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to