This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: i2c: add KConfig dependencies
Author:  Arnd Bergmann <>
Date:    Tue Jul 25 11:36:45 2017 -0400

The new ov5670 driver fails to build when VIDEO_V4L2_SUBDEV_API
or MEDIA_CONTROLLER are disabled:

drivers/media/i2c/ov5670.c: In function 'ov5670_open':
drivers/media/i2c/ov5670.c:1917:5: error: implicit declaration of function 
'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'? 
     v4l2_subdev_get_try_format(sd, fh->pad, 0);
drivers/media/i2c/ov5670.c:1917:38: error: 'struct v4l2_subdev_fh' has no 
member named 'pad'
     v4l2_subdev_get_try_format(sd, fh->pad, 0);
drivers/media/i2c/ov5670.c: In function 'ov5670_do_get_pad_format':
drivers/media/i2c/ov5670.c:2198:17: error: invalid type argument of unary '*' 
(have 'int')
   fmt->format = *v4l2_subdev_get_try_format(&ov5670->sd, cfg,
drivers/media/i2c/ov5670.c: At top level:
drivers/media/i2c/ov5670.c:2444:19: error: 'v4l2_subdev_link_validate' 
undeclared here (not in a function); did you mean 'v4l2_subdev_init'?
  .link_validate = v4l2_subdev_link_validate,
drivers/media/i2c/ov5670.c: In function 'ov5670_probe':
drivers/media/i2c/ov5670.c:2492:12: error: 'struct v4l2_subdev' has no member 
named 'entity'

This adds both to the Kconfig entry.

Fixes: 5de35c9b8dcd ("media: i2c: Add Omnivision OV5670 5M sensor support")

Signed-off-by: Arnd Bergmann <>
Signed-off-by: Hans Verkuil <>
Signed-off-by: Mauro Carvalho Chehab <>

 drivers/media/i2c/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index a05e40ecba7c..94153895fcd4 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -618,8 +618,9 @@ config VIDEO_OV6650
 config VIDEO_OV5670
        tristate "OmniVision OV5670 sensor support"
-       depends on I2C && VIDEO_V4L2
+       depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
        depends on MEDIA_CAMERA_SUPPORT
+       depends on MEDIA_CONTROLLER
        select V4L2_FWNODE
          This is a Video4Linux2 sensor-level driver for the OmniVision

linuxtv-commits mailing list

Reply via email to