This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: v4l: omap_vout: vrfb: initialize DMA flags
Author:  Arnd Bergmann <>
Date:    Wed Jul 26 11:23:07 2017 -0400

Passing uninitialized flags into device_prep_interleaved_dma is clearly
a bad idea, and we get a compiler warning for it:

drivers/media/platform/omap/omap_vout_vrfb.c: In function 
drivers/media/platform/omap/omap_vout_vrfb.c:273:5: error: 'flags' may be used 
uninitialized in this function [-Werror=maybe-uninitialized]

It seems that the OMAP dmaengine ignores the flags, but we should
pick the right ones anyway. This sets the flags I guessed based
on what other drivers used, and Peter confirmed that they are the
right ones.

Fixes: 6a1560ecaa8c ("media: v4l: omap_vout: vrfb: Convert to dmaengine")

Acked-by: Peter Ujfalusi <>
Signed-off-by: Arnd Bergmann <>
Signed-off-by: Hans Verkuil <>
Signed-off-by: Mauro Carvalho Chehab <>

 drivers/media/platform/omap/omap_vout_vrfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/drivers/media/platform/omap/omap_vout_vrfb.c 
index 040eacc45168..123c2b26a933 100644
--- a/drivers/media/platform/omap/omap_vout_vrfb.c
+++ b/drivers/media/platform/omap/omap_vout_vrfb.c
@@ -234,7 +234,7 @@ int omap_vout_prepare_vrfb(struct omap_vout_device *vout,
                           struct videobuf_buffer *vb)
        struct dma_async_tx_descriptor *tx;
-       enum dma_ctrl_flags flags;
+       enum dma_ctrl_flags flags = DMA_PREP_INTERRUPT | DMA_CTRL_ACK;
        struct dma_chan *chan = vout->vrfb_dma_tx.chan;
        struct dma_device *dmadev = chan->device;
        struct dma_interleaved_template *xt = vout->vrfb_dma_tx.xt;

linuxtv-commits mailing list

Reply via email to