This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/cgit.cgi/v4l-utils.git tree:

Subject: cec-ctl: improve the low drive max length check
Author:  Hans Verkuil <hans.verk...@cisco.com>
Date:    Fri Feb 9 14:49:28 2018 +0100

If the low drive starts at the end of a 0 bit, then the actual
maximum time that the bus can be low is the two summed (the time
the bus was low for the 0 bit and the time of the low drive
itself).

The earlier test was too strict.

Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>

 utils/cec-ctl/cec-pin.cpp | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

---

http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=7dbb7a13901dadb1af2dec5424f605e827b3fa75
diff --git a/utils/cec-ctl/cec-pin.cpp b/utils/cec-ctl/cec-pin.cpp
index 3537c03e1117..46fc62f480f8 100644
--- a/utils/cec-ctl/cec-pin.cpp
+++ b/utils/cec-ctl/cec-pin.cpp
@@ -250,9 +250,16 @@ static void cec_pin_rx_data_bit_was_high(bool is_high, 
__u64 ev_ts,
 
 static void cec_pin_rx_data_bit_was_low(__u64 ev_ts, __u64 usecs, __u64 
usecs_min, bool show)
 {
+       /*
+        * If the low drive starts at the end of a 0 bit, then the actual
+        * maximum time that the bus can be low is the two summed.
+        */
+       const unsigned max_low_drive = CEC_TIM_LOW_DRIVE_ERROR_MAX +
+               CEC_TIM_DATA_BIT_0_LOW_MAX + CEC_TIM_MARGIN;
+
        low_usecs = usecs;
        if (usecs >= CEC_TIM_LOW_DRIVE_ERROR_MIN - CEC_TIM_MARGIN) {
-               if (usecs_min >= CEC_TIM_LOW_DRIVE_ERROR_MAX && show)
+               if (usecs >= max_low_drive && show)
                        printf("%10.06f: warn: low drive too long (%.2f > %.2f 
ms)\n\n",
                               ts, usecs / 1000.0,
                               CEC_TIM_LOW_DRIVE_ERROR_MAX / 1000.0);

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to