This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: imx-media-csi: Do not propagate the error when pinctrl is not 
Author:  Fabio Estevam <>
Date:    Sat Mar 3 07:56:30 2018 -0500

Since commit 52e17089d185 ("media: imx: Don't initialize vars that
won't be used") imx_csi_probe() fails to probe after propagating the
devm_pinctrl_get_select_default() error.

devm_pinctrl_get_select_default() may return -ENODEV when the CSI pinctrl
entry is not found, so better not to propagate the error in the -ENODEV
case to avoid a regression.

Suggested-by: Philipp Zabel <>
Signed-off-by: Fabio Estevam <>
Reviewed-by: Steve Longerbeam <>
Signed-off-by: Hans Verkuil <>
Signed-off-by: Mauro Carvalho Chehab <>

 drivers/staging/media/imx/imx-media-csi.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)


diff --git a/drivers/staging/media/imx/imx-media-csi.c 
index 00c9d625cfb5..16cab40156ca 100644
--- a/drivers/staging/media/imx/imx-media-csi.c
+++ b/drivers/staging/media/imx/imx-media-csi.c
@@ -1800,7 +1800,10 @@ static int imx_csi_probe(struct platform_device *pdev)
        pinctrl = devm_pinctrl_get_select_default(priv->dev);
        if (IS_ERR(pinctrl)) {
                ret = PTR_ERR(priv->vdev);
-               goto free;
+               dev_dbg(priv->dev,
+                       "devm_pinctrl_get_select_default() failed: %d\n", ret);
+               if (ret != -ENODEV)
+                       goto free;
        ret = v4l2_async_register_subdev(&priv->sd);

linuxtv-commits mailing list

Reply via email to