This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: venus: vdec: fix format enumeration
Author:  Alexandre Courbot <acour...@chromium.org>
Date:    Mon Mar 19 05:32:29 2018 -0400

find_format_by_index() stops enumerating formats as soon as the index
matches, and returns NULL if venus_helper_check_codec() finds out that
the format is not supported. This prevents formats to be properly
enumerated if a non-supported format is present, as the enumeration will
end with it.

Fix this by moving the call to venus_helper_check_codec() into the loop,
and keep enumerating when it fails.

Fixes: 29f0133ec6 media: venus: use helper function to check supported codecs

Signed-off-by: Alexandre Courbot <acour...@chromium.org>
Acked-by: Stanimir Varbanov <stanimir.varba...@linaro.org>
Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com>

 drivers/media/platform/qcom/venus/vdec.c | 13 +++++++------
 drivers/media/platform/qcom/venus/venc.c | 13 +++++++------
 2 files changed, 14 insertions(+), 12 deletions(-)

---

diff --git a/drivers/media/platform/qcom/venus/vdec.c 
b/drivers/media/platform/qcom/venus/vdec.c
index c9e9576bb08a..49bbd1861d3a 100644
--- a/drivers/media/platform/qcom/venus/vdec.c
+++ b/drivers/media/platform/qcom/venus/vdec.c
@@ -135,20 +135,21 @@ find_format_by_index(struct venus_inst *inst, unsigned 
int index, u32 type)
                return NULL;
 
        for (i = 0; i < size; i++) {
+               bool valid;
+
                if (fmt[i].type != type)
                        continue;
-               if (k == index)
+               valid = type != V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE ||
+                       venus_helper_check_codec(inst, fmt[i].pixfmt);
+               if (k == index && valid)
                        break;
-               k++;
+               if (valid)
+                       k++;
        }
 
        if (i == size)
                return NULL;
 
-       if (type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE &&
-           !venus_helper_check_codec(inst, fmt[i].pixfmt))
-               return NULL;
-
        return &fmt[i];
 }
 
diff --git a/drivers/media/platform/qcom/venus/venc.c 
b/drivers/media/platform/qcom/venus/venc.c
index e3a10a852cad..6b2ce479584e 100644
--- a/drivers/media/platform/qcom/venus/venc.c
+++ b/drivers/media/platform/qcom/venus/venc.c
@@ -120,20 +120,21 @@ find_format_by_index(struct venus_inst *inst, unsigned 
int index, u32 type)
                return NULL;
 
        for (i = 0; i < size; i++) {
+               bool valid;
+
                if (fmt[i].type != type)
                        continue;
-               if (k == index)
+               valid = type != V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE ||
+                       venus_helper_check_codec(inst, fmt[i].pixfmt);
+               if (k == index && valid)
                        break;
-               k++;
+               if (valid)
+                       k++;
        }
 
        if (i == size)
                return NULL;
 
-       if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE &&
-           !venus_helper_check_codec(inst, fmt[i].pixfmt))
-               return NULL;
-
        return &fmt[i];
 }
 

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to