This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: atomisp: get rid of a warning
Author:  Mauro Carvalho Chehab <[email protected]>
Date:    Thu Apr 12 05:44:33 2018 -0400

On smatch, this warning is trigged:

        drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c:324 
__bo_take_off_handling() error: we previously assumed 'bo->prev' could be null 
(see line 314)

Because it can't properly analize the truth table for the above
function. So, add an explicit check for the final condition there.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

---

diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c 
b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
index c888f9c809f9..a6620d2c9f50 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
@@ -319,7 +319,7 @@ static void __bo_take_off_handling(struct hmm_buffer_object 
*bo)
         *      to take off this bo, we just set take the "prev/next" pointers
         *      to NULL, the free rbtree stays unchaged
         */
-       } else {
+       } else if (bo->prev != NULL && bo->next != NULL) {
                bo->next->prev = bo->prev;
                bo->prev->next = bo->next;
                bo->next = NULL;

_______________________________________________
linuxtv-commits mailing list
[email protected]
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to