This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/cgit.cgi/v4l-utils.git tree:

Subject: v4l2-compliance: fix logic bug in testParm
Author:  Hans Verkuil <hans.verk...@cisco.com>
Date:    Tue Mar 27 13:18:09 2018 +0200

The check for video outputs was not correct.

Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>

 utils/v4l2-compliance/v4l2-test-formats.cpp | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

---

http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=88f31856e566df6e4d38eaff94c422fbb536febb
diff --git a/utils/v4l2-compliance/v4l2-test-formats.cpp 
b/utils/v4l2-compliance/v4l2-test-formats.cpp
index 5ee885d34180..0a00097a825e 100644
--- a/utils/v4l2-compliance/v4l2-test-formats.cpp
+++ b/utils/v4l2-compliance/v4l2-test-formats.cpp
@@ -1252,10 +1252,12 @@ int testParm(struct node *node)
                        return ret;
                if (!ret) {
                        supported = true;
-                       if (V4L2_TYPE_IS_OUTPUT(type) && !node->has_vid_out())
-                               return fail("video output caps not set, but 
G/S_PARM worked\n");
-                       else if (!node->has_vid_cap())
+                       if (V4L2_TYPE_IS_OUTPUT(type)) {
+                               if (!node->has_vid_out())
+                                       return fail("video output caps not set, 
but G/S_PARM worked\n");
+                       } else if (!node->has_vid_cap()) {
                                return fail("video capture caps not set, but 
G/S_PARM worked\n");
+                       }
                }
        }
 

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to