This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/cgit.cgi/v4l-utils.git tree:

Subject: cec-compliance: if MAX_RETRIES and OK were set, clear OK
Author:  Hans Verkuil <hans.verk...@cisco.com>
Date:    Mon Jul 23 12:37:47 2018 +0200

There was a bug in the CEC framework where tx_status could have
both OK and MAX_RETRIES flags set (this happened if a message
was canceled). The cec-compliance utility did warn about this, but
still passed tx_status on as-is. So clear the incorrect OK flag
instead to avoid problems with this.

Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>

 utils/cec-compliance/cec-compliance.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

---

http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=5a99dc69d0bf79bedadd5c9675033a8815fceb0e
diff --git a/utils/cec-compliance/cec-compliance.cpp 
b/utils/cec-compliance/cec-compliance.cpp
index 2c44a571d3a3..66b102dc5c62 100644
--- a/utils/cec-compliance/cec-compliance.cpp
+++ b/utils/cec-compliance/cec-compliance.cpp
@@ -703,8 +703,10 @@ int cec_named_ioctl(struct node *node, const char *name,
        }
 
        if (!retval && request == CEC_TRANSMIT &&
-           (msg->tx_status & CEC_TX_STATUS_OK) && ((msg->tx_status & 
CEC_TX_STATUS_MAX_RETRIES)))
+           (msg->tx_status & CEC_TX_STATUS_OK) && ((msg->tx_status & 
CEC_TX_STATUS_MAX_RETRIES))) {
                warn("Both OK and MAX_RETRIES were set in tx_status!\n");
+               msg->tx_status &= ~CEC_TX_STATUS_OK;
+       }
 
        if (!retval && request == CEC_TRANSMIT && show_info) {
                printf("\t\t%s: Sequence: %u Tx Timestamp: %s Length: %u",

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to