This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/cgit.cgi/v4l-utils.git tree:

Subject: v4l2-compliance: enable 'reserved' checks for media
Author:  Hans Verkuil <hans.verk...@cisco.com>
Date:    Sat Jun 23 11:46:07 2018 +0200

The media core code has been updated to properly zero these
reserved arrays, so we can now check them with v4l2-compliance.

Uncomment those checks.

Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>

 utils/v4l2-compliance/v4l2-test-media.cpp | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

---

http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=2e2a3a90a19c5f2e45b889a63c96e12c7678149b
diff --git a/utils/v4l2-compliance/v4l2-test-media.cpp 
b/utils/v4l2-compliance/v4l2-test-media.cpp
index 9c10f95b4e89..54c8e2e7d5f4 100644
--- a/utils/v4l2-compliance/v4l2-test-media.cpp
+++ b/utils/v4l2-compliance/v4l2-test-media.cpp
@@ -115,10 +115,10 @@ int testMediaTopology(struct node *node)
        fail_on_test(topology.num_interfaces == ~0U);
        fail_on_test(topology.num_pads == ~0U);
        fail_on_test(topology.num_links == ~0U);
-       //fail_on_test(topology.reserved1);
-       //fail_on_test(topology.reserved2);
-       //fail_on_test(topology.reserved3);
-       //fail_on_test(topology.reserved4);
+       fail_on_test(topology.reserved1);
+       fail_on_test(topology.reserved2);
+       fail_on_test(topology.reserved3);
+       fail_on_test(topology.reserved4);
        topology.ptr_entities = 4;
        fail_on_test(doioctl(node, MEDIA_IOC_G_TOPOLOGY, &topology) != EFAULT);
        topology.ptr_entities = 0;
@@ -437,7 +437,7 @@ int testMediaSetupLink(struct node *node)
                link = link_disabled;
                memset(link.reserved, 0xff, sizeof(link.reserved));
                fail_on_test(doioctl(node, MEDIA_IOC_SETUP_LINK, &link));
-               //fail_on_test(check_0(link.reserved, sizeof(link.reserved)));
+               fail_on_test(check_0(link.reserved, sizeof(link.reserved)));
                link.flags |= MEDIA_LNK_FL_INTERFACE_LINK;
                fail_on_test(doioctl(node, MEDIA_IOC_SETUP_LINK, &link) != 
EINVAL);
        }
@@ -445,7 +445,7 @@ int testMediaSetupLink(struct node *node)
                link = link_enabled;
                memset(link.reserved, 0xff, sizeof(link.reserved));
                fail_on_test(doioctl(node, MEDIA_IOC_SETUP_LINK, &link));
-               //fail_on_test(check_0(link.reserved, sizeof(link.reserved)));
+               fail_on_test(check_0(link.reserved, sizeof(link.reserved)));
                link.flags |= MEDIA_LNK_FL_INTERFACE_LINK;
                fail_on_test(doioctl(node, MEDIA_IOC_SETUP_LINK, &link) != 
EINVAL);
        }

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to