This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/cgit.cgi/v4l-utils.git tree:

Subject: v4l2-compliance: fix and comment out qbuf test
Author:  Hans Verkuil <hverkuil-ci...@xs4all.nl>
Date:    Mon Apr 1 14:06:29 2019 +0200

The fail_on_test(qbuf()) check was missing a !.

But if after this correctly-failing qbuf() the querybuf ioctl is
called again, all the request information is dropped from the result.

So comment this out while a investigation this.

Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>
Fixes: 7ee189ecae01 ("v4l2-compliance: fix request API test")

 utils/v4l2-compliance/v4l2-test-buffers.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

---

http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=0efd87d4058697347797239cad13cb4231438f19
diff --git a/utils/v4l2-compliance/v4l2-test-buffers.cpp 
b/utils/v4l2-compliance/v4l2-test-buffers.cpp
index 9442032640b5..781a23f491fd 100644
--- a/utils/v4l2-compliance/v4l2-test-buffers.cpp
+++ b/utils/v4l2-compliance/v4l2-test-buffers.cpp
@@ -1814,7 +1814,9 @@ int testRequests(struct node *node, bool test_streaming)
                int err = buf.qbuf(node);
                if (!err) {
                        fail_on_test(!supports_requests);
-                       fail_on_test(buf.qbuf(node));
+                       // After this call querybuf won't set
+                       // V4L2_BUF_FLAG_REQUEST_FD. Disable this test for now.
+                       // fail_on_test(!buf.qbuf(node));
                } else {
                        fail_on_test(supports_requests);
                        fail_on_test(err != EBADR);

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to