This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: ov8856: Check reading clock frequency succeeded
Author:  Sakari Ailus <sakari.ai...@linux.intel.com>
Date:    Wed Aug 7 05:34:43 2019 -0300

Instead of blindly trusting getting the clock frequency succeeded end then
testing it against a pre-defined value, verify reading the value
succeeded.

Fixes: 879347f0c258 ("media: ov8856: Add support for OV8856 sensor")
Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org>

 drivers/media/i2c/ov8856.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

---

diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c
index cd347d6b7b9d..8655842af275 100644
--- a/drivers/media/i2c/ov8856.c
+++ b/drivers/media/i2c/ov8856.c
@@ -1106,7 +1106,10 @@ static int ov8856_check_hwcfg(struct device *dev)
        if (!fwnode)
                return -ENXIO;
 
-       fwnode_property_read_u32(fwnode, "clock-frequency", &mclk);
+       ret = fwnode_property_read_u32(fwnode, "clock-frequency", &mclk);
+       if (ret)
+               return ret;
+
        if (mclk != OV8856_MCLK) {
                dev_err(dev, "external clock %d is not supported", mclk);
                return -EINVAL;

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to