This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: i2c: ov2659: fix s_stream return value
Author:  Benoit Parrot <bpar...@ti.com>
Date:    Mon Sep 30 10:06:40 2019 -0300

In ov2659_s_stream() return value for invoked function should be checked
and propagated.

Signed-off-by: Benoit Parrot <bpar...@ti.com>
Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org>

 drivers/media/i2c/ov2659.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

---

diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
index f77320e8a60d..da181a13cf44 100644
--- a/drivers/media/i2c/ov2659.c
+++ b/drivers/media/i2c/ov2659.c
@@ -1187,11 +1187,15 @@ static int ov2659_s_stream(struct v4l2_subdev *sd, int 
on)
                goto unlock;
        }
 
-       ov2659_set_pixel_clock(ov2659);
-       ov2659_set_frame_size(ov2659);
-       ov2659_set_format(ov2659);
-       ov2659_set_streaming(ov2659, 1);
-       ov2659->streaming = on;
+       ret = ov2659_set_pixel_clock(ov2659);
+       if (!ret)
+               ret = ov2659_set_frame_size(ov2659);
+       if (!ret)
+               ret = ov2659_set_format(ov2659);
+       if (!ret) {
+               ov2659_set_streaming(ov2659, 1);
+               ov2659->streaming = on;
+       }
 
 unlock:
        mutex_unlock(&ov2659->lock);

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to