This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: mantis: fix two smatch errors
Author:  Hans Verkuil <hverkuil-ci...@xs4all.nl>
Date:    Sun Nov 3 12:23:38 2019 +0100

Drop two dprintk's that relied on a non-NULL mantis pointer
when it was in fact a NULL pointer.

Fix those warnings:

drivers/media/pci/mantis/mantis_cards.c:73 mantis_irq_handler() error: we 
previously assumed 'mantis' could be null (see line 72)
drivers/media/pci/mantis/hopper_cards.c:64 hopper_irq_handler() error: we 
previously assumed 'mantis' could be null (see line 63)

Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mche...@kernel.org>

 drivers/media/pci/mantis/hopper_cards.c | 4 +---
 drivers/media/pci/mantis/mantis_cards.c | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

---

diff --git a/drivers/media/pci/mantis/hopper_cards.c 
b/drivers/media/pci/mantis/hopper_cards.c
index 67aebe759232..c0bd5d7e148b 100644
--- a/drivers/media/pci/mantis/hopper_cards.c
+++ b/drivers/media/pci/mantis/hopper_cards.c
@@ -60,10 +60,8 @@ static irqreturn_t hopper_irq_handler(int irq, void *dev_id)
        struct mantis_ca *ca;
 
        mantis = (struct mantis_pci *) dev_id;
-       if (unlikely(!mantis)) {
-               dprintk(MANTIS_ERROR, 1, "Mantis == NULL");
+       if (unlikely(!mantis))
                return IRQ_NONE;
-       }
        ca = mantis->mantis_ca;
 
        stat = mmread(MANTIS_INT_STAT);
diff --git a/drivers/media/pci/mantis/mantis_cards.c 
b/drivers/media/pci/mantis/mantis_cards.c
index deadd0b92233..906e4500d87d 100644
--- a/drivers/media/pci/mantis/mantis_cards.c
+++ b/drivers/media/pci/mantis/mantis_cards.c
@@ -69,10 +69,8 @@ static irqreturn_t mantis_irq_handler(int irq, void *dev_id)
        struct mantis_ca *ca;
 
        mantis = (struct mantis_pci *) dev_id;
-       if (unlikely(mantis == NULL)) {
-               dprintk(MANTIS_ERROR, 1, "Mantis == NULL");
+       if (unlikely(!mantis))
                return IRQ_NONE;
-       }
        ca = mantis->mantis_ca;
 
        stat = mmread(MANTIS_INT_STAT);

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to