This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: hantro: Set H264 FIELDPIC_FLAG_E flag correctly
Author:  Jonas Karlman <>
Date:    Wed Nov 6 23:35:11 2019 +0100

The FIELDPIC_FLAG_E bit should be set when field_pic_flag exists in stream,
it is currently set based on field_pic_flag of current frame.
The PIC_FIELDMODE_E bit is correctly set based on the field_pic_flag.

Fix this by setting the FIELDPIC_FLAG_E bit when frame_mbs_only is not set.

Fixes: dea0a82f3d22 ("media: hantro: Add support for H264 decoding on G1")
Signed-off-by: Jonas Karlman <>
Reviewed-by: Boris Brezillon <>
Signed-off-by: Hans Verkuil <>
Signed-off-by: Mauro Carvalho Chehab <>

 drivers/staging/media/hantro/hantro_g1_h264_dec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/drivers/staging/media/hantro/hantro_g1_h264_dec.c 
index 27d40d8d3728..3cd40a8f0daa 100644
--- a/drivers/staging/media/hantro/hantro_g1_h264_dec.c
+++ b/drivers/staging/media/hantro/hantro_g1_h264_dec.c
@@ -63,7 +63,7 @@ static void set_params(struct hantro_ctx *ctx)
        /* always use the matrix sent from userspace */
        reg |= G1_REG_DEC_CTRL2_TYPE1_QUANT_E;
-       if (slices[0].flags &  V4L2_H264_SLICE_FLAG_FIELD_PIC)
+       if (!(sps->flags & V4L2_H264_SPS_FLAG_FRAME_MBS_ONLY))
                reg |= G1_REG_DEC_CTRL2_FIELDPIC_FLAG_E;
        vdpu_write_relaxed(vpu, reg, G1_REG_DEC_CTRL2);

linuxtv-commits mailing list

Reply via email to