This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: ti-vpe: cal: fix write to unallocated memory
Author:  Tomi Valkeinen <[email protected]>
Date:    Wed Jan 13 10:00:27 2021 +0100

The asd allocated with v4l2_async_notifier_add_fwnode_subdev() must be
of size cal_v4l2_async_subdev, otherwise access to
cal_v4l2_async_subdev->phy will go to unallocated memory.

Fixes: 8fcb7576ad19 ("media: ti-vpe: cal: Allow multiple contexts per subdev 
notifier")
Signed-off-by: Tomi Valkeinen <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/media/platform/ti-vpe/cal.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

---

diff --git a/drivers/media/platform/ti-vpe/cal.c 
b/drivers/media/platform/ti-vpe/cal.c
index 293cbac905b3..5fb627811c6b 100644
--- a/drivers/media/platform/ti-vpe/cal.c
+++ b/drivers/media/platform/ti-vpe/cal.c
@@ -607,7 +607,7 @@ static irqreturn_t cal_irq(int irq_cal, void *data)
  */
 
 struct cal_v4l2_async_subdev {
-       struct v4l2_async_subdev asd;
+       struct v4l2_async_subdev asd; /* Must be first */
        struct cal_camerarx *phy;
 };
 
@@ -694,7 +694,7 @@ static int cal_async_notifier_register(struct cal_dev *cal)
                fwnode = of_fwnode_handle(phy->sensor_node);
                asd = v4l2_async_notifier_add_fwnode_subdev(&cal->notifier,
                                                            fwnode,
-                                                           sizeof(*asd));
+                                                           sizeof(*casd));
                if (IS_ERR(asd)) {
                        phy_err(phy, "Failed to add subdev to notifier\n");
                        ret = PTR_ERR(asd);

_______________________________________________
linuxtv-commits mailing list
[email protected]
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to