This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: siano: fix device register error path
Author:  Mauro Carvalho Chehab <[email protected]>
Date:    Thu Jun 10 08:57:02 2021 +0200

As reported by smatch:
        drivers/media/common/siano/smsdvb-main.c:1231 smsdvb_hotplug() warn: 
'&client->entry' not removed from list

If an error occur at the end of the registration logic, it won't
drop the device from the list.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/media/common/siano/smsdvb-main.c | 4 ++++
 1 file changed, 4 insertions(+)

---

diff --git a/drivers/media/common/siano/smsdvb-main.c 
b/drivers/media/common/siano/smsdvb-main.c
index b8a163a47d09..f80caaa333da 100644
--- a/drivers/media/common/siano/smsdvb-main.c
+++ b/drivers/media/common/siano/smsdvb-main.c
@@ -1212,6 +1212,10 @@ static int smsdvb_hotplug(struct smscore_device_t 
*coredev,
        return 0;
 
 media_graph_error:
+       mutex_lock(&g_smsdvb_clientslock);
+       list_del(&client->entry);
+       mutex_unlock(&g_smsdvb_clientslock);
+
        smsdvb_debugfs_release(client);
 
 client_error:

_______________________________________________
linuxtv-commits mailing list
[email protected]
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to