This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: atomisp: fix enum_fmt logic
Author:  Mauro Carvalho Chehab <[email protected]>
Date:    Thu Nov 4 11:27:55 2021 +0000

Currently, the enum lists the sensor's native format as a
supported format. However, trying to setup a pipeline using
it doesn't work.

So, exclude such formats from the enum.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

---

diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c 
b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
index 8df052f6190d..30483a84ed80 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
@@ -775,6 +775,7 @@ static int atomisp_enum_fmt_cap(struct file *file, void *fh,
        struct v4l2_subdev_mbus_code_enum code = {
                .which = V4L2_SUBDEV_FORMAT_ACTIVE,
        };
+       const struct atomisp_format_bridge *format;
        struct v4l2_subdev *camera;
        unsigned int i, fi = 0;
        int rval;
@@ -806,15 +807,15 @@ static int atomisp_enum_fmt_cap(struct file *file, void 
*fh,
                return rval;
 
        for (i = 0; i < ARRAY_SIZE(atomisp_output_fmts); i++) {
-               const struct atomisp_format_bridge *format =
-                           &atomisp_output_fmts[i];
+               format = &atomisp_output_fmts[i];
 
                /*
                 * Is the atomisp-supported format is valid for the
                 * sensor (configuration)? If not, skip it.
+                *
+                * FIXME: fix the pipeline to allow sensor format too.
                 */
-               if (format->sh_fmt == IA_CSS_FRAME_FORMAT_RAW
-                   && format->mbus_code != code.code)
+               if (format->sh_fmt == IA_CSS_FRAME_FORMAT_RAW)
                        continue;
 
                /* Found a match. Now let's pick f->index'th one. */

_______________________________________________
linuxtv-commits mailing list
[email protected]
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to