This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: camss: csid-170: don't enable unused irqs
Author:  Jonathan Marek <[email protected]>
Date:    Wed Dec 22 01:37:38 2021 +0100

csid_isr() only checks for the reset irq, so enabling any other irqs
doesn't make sense. The "RDI irq" comment is also wrong, the register
should be CSID_CSI2_RDIN_IRQ_MASK. Without this fix there may be an
excessive amount of irqs.

Fixes: eebe6d00e9bf ("media: camss: Add support for CSID hardware version Titan 
170")
Signed-off-by: Jonathan Marek <[email protected]>
Reviewed-by: Robert Foss <[email protected]>
Tested-by: Julian Grahsl <[email protected]>
Tested-by: Bryan O'Donoghue <[email protected]>
Signed-off-by: Bryan O'Donoghue <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/media/platform/qcom/camss/camss-csid-170.c | 6 ------
 1 file changed, 6 deletions(-)

---

diff --git a/drivers/media/platform/qcom/camss/camss-csid-170.c 
b/drivers/media/platform/qcom/camss/camss-csid-170.c
index aa65043c3303..a006c8dbceb1 100644
--- a/drivers/media/platform/qcom/camss/camss-csid-170.c
+++ b/drivers/media/platform/qcom/camss/camss-csid-170.c
@@ -444,12 +444,6 @@ static void csid_configure_stream(struct csid_device 
*csid, u8 enable)
        val |= 1 << CSI2_RX_CFG1_MISR_EN;
        writel_relaxed(val, csid->base + CSID_CSI2_RX_CFG1); // 
csi2_vc_mode_shift_val ?
 
-       /* error irqs start at BIT(11) */
-       writel_relaxed(~0u, csid->base + CSID_CSI2_RX_IRQ_MASK);
-
-       /* RDI irq */
-       writel_relaxed(~0u, csid->base + CSID_TOP_IRQ_MASK);
-
        val = 1 << RDI_CTRL_HALT_CMD;
        writel_relaxed(val, csid->base + CSID_RDI_CTRL(0));
 }

_______________________________________________
linuxtv-commits mailing list
[email protected]
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to