This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: staging: media: imx: imx7-mipi-csis: Make subdev name unique
Author:  Laurent Pinchart <[email protected]>
Date:    Fri Jun 25 04:26:35 2021 +0200

When multiple CSIS instances are present in a single graph, they are
currently all named "imx7-mipi-csis.0", which breaks the entity name
uniqueness requirement. Fix it by using the device name to create the
subdev name.

Fixes: 7807063b862b ("media: staging/imx7: add MIPI CSI-2 receiver subdev for 
i.MX7")
Signed-off-by: Laurent Pinchart <[email protected]>
Reviewed-by: Rui Miguel Silva <[email protected]>
Reviewed-by: Sakari Ailus <[email protected]>
Reviewed-by: Jerome Brunet <[email protected]>
Tested-by: Jerome Brunet <[email protected]> # On i.MX8MP
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/staging/media/imx/imx7-mipi-csis.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

---

diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c 
b/drivers/staging/media/imx/imx7-mipi-csis.c
index d2f60403eb41..a8710dc24560 100644
--- a/drivers/staging/media/imx/imx7-mipi-csis.c
+++ b/drivers/staging/media/imx/imx7-mipi-csis.c
@@ -32,7 +32,6 @@
 #include <media/v4l2-subdev.h>
 
 #define CSIS_DRIVER_NAME                       "imx7-mipi-csis"
-#define CSIS_SUBDEV_NAME                       CSIS_DRIVER_NAME
 
 #define CSIS_PAD_SINK                          0
 #define CSIS_PAD_SOURCE                                1
@@ -313,7 +312,6 @@ struct csi_state {
        struct reset_control *mrst;
        struct regulator *mipi_phy_regulator;
        const struct mipi_csis_info *info;
-       u8 index;
 
        struct v4l2_subdev sd;
        struct media_pad pads[CSIS_PADS_NUM];
@@ -1329,8 +1327,8 @@ static int mipi_csis_subdev_init(struct csi_state *state)
 
        v4l2_subdev_init(sd, &mipi_csis_subdev_ops);
        sd->owner = THIS_MODULE;
-       snprintf(sd->name, sizeof(sd->name), "%s.%d",
-                CSIS_SUBDEV_NAME, state->index);
+       snprintf(sd->name, sizeof(sd->name), "csis-%s",
+                dev_name(state->dev));
 
        sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
        sd->ctrl_handler = NULL;

_______________________________________________
linuxtv-commits mailing list
[email protected]
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to