This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: saa7134: use swap() to make code cleaner
Author:  Yang Guang <[email protected]>
Date:    Mon Dec 20 08:46:46 2021 +0100

Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: David Yang <[email protected]>
Signed-off-by: Yang Guang <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/media/pci/saa7134/saa7134-video.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

---

diff --git a/drivers/media/pci/saa7134/saa7134-video.c 
b/drivers/media/pci/saa7134/saa7134-video.c
index 374c8e1087de..7bc4c7709f4d 100644
--- a/drivers/media/pci/saa7134/saa7134-video.c
+++ b/drivers/media/pci/saa7134/saa7134-video.c
@@ -823,7 +823,7 @@ static int buffer_activate(struct saa7134_dev *dev,
 {
        struct saa7134_dmaqueue *dmaq = buf->vb2.vb2_buf.vb2_queue->drv_priv;
        unsigned long base,control,bpl;
-       unsigned long bpl_uv,lines_uv,base2,base3,tmp; /* planar */
+       unsigned long bpl_uv, lines_uv, base2, base3; /* planar */
 
        video_dbg("buffer_activate buf=%p\n", buf);
        buf->top_seen = 0;
@@ -868,11 +868,8 @@ static int buffer_activate(struct saa7134_dev *dev,
                lines_uv = dev->height >> dev->fmt->vshift;
                base2    = base + bpl * dev->height;
                base3    = base2 + bpl_uv * lines_uv;
-               if (dev->fmt->uvswap) {
-                       tmp = base2;
-                       base2 = base3;
-                       base3 = tmp;
-               }
+               if (dev->fmt->uvswap)
+                       swap(base2, base3);
                video_dbg("uv: bpl=%ld lines=%ld base2/3=%ld/%ld\n",
                        bpl_uv,lines_uv,base2,base3);
                if (V4L2_FIELD_HAS_BOTH(dev->field)) {

_______________________________________________
linuxtv-commits mailing list
[email protected]
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to