This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: camss: vfe-170: fix "VFE halt timeout" error
Author:  Jonathan Marek <[email protected]>
Date:    Wed Dec 22 01:37:45 2021 +0100

This function waits for halt_complete but doesn't do anything to cause
it to complete, and always hits the "VFE halt timeout" error. Just delete
this code for now.

Fixes: 7319cdf189bb ("media: camss: Add support for VFE hardware version Titan 
170")
Signed-off-by: Jonathan Marek <[email protected]>
Reviewed-by: Robert Foss <[email protected]>
Tested-by: Julian Grahsl <[email protected]>
Tested-by: Bryan O'Donoghue <[email protected]>
Signed-off-by: Bryan O'Donoghue <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/media/platform/qcom/camss/camss-vfe-170.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

---

diff --git a/drivers/media/platform/qcom/camss/camss-vfe-170.c 
b/drivers/media/platform/qcom/camss/camss-vfe-170.c
index f524af712a84..600150cfc4f7 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe-170.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe-170.c
@@ -395,17 +395,7 @@ static irqreturn_t vfe_isr(int irq, void *dev)
  */
 static int vfe_halt(struct vfe_device *vfe)
 {
-       unsigned long time;
-
-       reinit_completion(&vfe->halt_complete);
-
-       time = wait_for_completion_timeout(&vfe->halt_complete,
-                                          
msecs_to_jiffies(VFE_HALT_TIMEOUT_MS));
-       if (!time) {
-               dev_err(vfe->camss->dev, "VFE halt timeout\n");
-               return -EIO;
-       }
-
+       /* rely on vfe_disable_output() to stop the VFE */
        return 0;
 }
 

_______________________________________________
linuxtv-commits mailing list
[email protected]
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to