This is an automatic generated email to let you know that the following patch 
were queued at the 
http://git.linuxtv.org/cgit.cgi/v4l-utils.git tree:

Subject: cec-ctl: only generate eob for CEC pin events
Author:  Hans Verkuil <[email protected]>
Date:    Thu Mar 3 09:50:50 2022 +0100

An end-of-bit event is generated if a CEC pin event arrives that
indicates that the CEC bus remained high for longer than a bit period,
which means that it was the end of the message.

But this was also done for HPD/5V events, which is incorrect.
Especially since HPD/5V events might have a timestamp that is
later than a CEC event (probably due to a driver or framework
bug). In any case, the eob generator has nothing to do with HPD/5V
events.

Signed-off-by: Hans Verkuil <[email protected]>

 utils/cec-ctl/cec-ctl.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

---

http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=482610beb4a0d9e5d12783f1b734945677782c2e
diff --git a/utils/cec-ctl/cec-ctl.cpp b/utils/cec-ctl/cec-ctl.cpp
index 202078425e74..b0073b3949cd 100644
--- a/utils/cec-ctl/cec-ctl.cpp
+++ b/utils/cec-ctl/cec-ctl.cpp
@@ -972,7 +972,9 @@ static void monitor(const struct node &node, __u32 
monitor_time, const char *sto
                            ev.event == CEC_EVENT_PIN_5V_LOW ||
                            ev.event == CEC_EVENT_PIN_5V_HIGH)
                                pin_event = true;
-                       generate_eob_event(ev.ts, fstore);
+                       if (ev.event == CEC_EVENT_PIN_CEC_LOW ||
+                           ev.event == CEC_EVENT_PIN_CEC_HIGH)
+                               generate_eob_event(ev.ts, fstore);
                        if (pin_event && fstore) {
                                unsigned int v = ev.event - 
CEC_EVENT_PIN_CEC_LOW;
 

_______________________________________________
linuxtv-commits mailing list
[email protected]
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to