This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: staging/intel-ipu3: Cleanup dummy buffers via helper
Author:  Umang Jain <[email protected]>
Date:    Fri Mar 18 12:18:26 2022 +0000

Use an existing helper imgu_video_nodes_exit() on imgu-video-node
initialization failure path to cleanup dummy buffers.

Signed-off-by: Umang Jain <[email protected]>
Reviewed-by: Laurent Pinchart <[email protected]>
Signed-off-by: Sakari Ailus <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

 drivers/staging/media/ipu3/ipu3.c | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

---

diff --git a/drivers/staging/media/ipu3/ipu3.c 
b/drivers/staging/media/ipu3/ipu3.c
index 8e1e9e46e604..0c453b37f8c4 100644
--- a/drivers/staging/media/ipu3/ipu3.c
+++ b/drivers/staging/media/ipu3/ipu3.c
@@ -440,6 +440,16 @@ fail_start_streaming:
        return r;
 }
 
+static void imgu_video_nodes_exit(struct imgu_device *imgu)
+{
+       int i;
+
+       for (i = 0; i < IMGU_MAX_PIPE_NUM; i++)
+               imgu_dummybufs_cleanup(imgu, i);
+
+       imgu_v4l2_unregister(imgu);
+}
+
 static int imgu_video_nodes_init(struct imgu_device *imgu)
 {
        struct v4l2_pix_format_mplane *fmts[IPU3_CSS_QUEUES] = { NULL };
@@ -489,24 +499,11 @@ static int imgu_video_nodes_init(struct imgu_device *imgu)
        return 0;
 
 out_cleanup:
-       for (j = 0; j < IMGU_MAX_PIPE_NUM; j++)
-               imgu_dummybufs_cleanup(imgu, j);
-
-       imgu_v4l2_unregister(imgu);
+       imgu_video_nodes_exit(imgu);
 
        return r;
 }
 
-static void imgu_video_nodes_exit(struct imgu_device *imgu)
-{
-       int i;
-
-       for (i = 0; i < IMGU_MAX_PIPE_NUM; i++)
-               imgu_dummybufs_cleanup(imgu, i);
-
-       imgu_v4l2_unregister(imgu);
-}
-
 /**************** PCI interface ****************/
 
 static irqreturn_t imgu_isr_threaded(int irq, void *imgu_ptr)

_______________________________________________
linuxtv-commits mailing list
[email protected]
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to